Last modified: 2011-11-17 00:45:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 24465 - Allow more detailed formatting of log entries
Allow more detailed formatting of log entries
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-20 21:22 UTC by Michael Newton
Modified: 2011-11-17 00:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
implementation of $wgLogFormatters (562 bytes, patch)
2010-07-20 21:22 UTC, Michael Newton
Details
updated patch for 1.17.0 (1.07 KB, patch)
2011-11-14 21:03 UTC, Michael Newton
Details

Description Michael Newton 2010-07-20 21:22:37 UTC
Created attachment 7579 [details]
implementation of $wgLogFormatters

$wgLogActions does not provide for a lot of fine-grained control over log entries; I wrote an extension to log failed login attempts to our wiki, which involved displaying entries for non-existent users. I ended up implementing something which let me intercept the individual entries before they were displayed. Attached are the changes I made against 1.15.3.
Comment 1 p858snake 2011-04-30 00:09:40 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 2 Sumana Harihareswara 2011-11-10 05:58:50 UTC
Michael, thank you for your patch, and my apologies that it's gone so long without a response.  I'm adding the "need-review" keyword to signal that someone should review your patch.  If you have the time and the interest, could you rebase it against current MediaWiki trunk in Subversion?  Thanks!
Comment 3 Sam Reed (reedy) 2011-11-13 23:01:04 UTC
Although minor (and would be easy to fix), this patch has register_globals issues, as the variable is not defined in DefaultSettings.php setting it to an empty array

!empty should become isset too

Using a global to store functions seems a bit icky, wouldn't this possibly make more sense as a hook?
Comment 4 Michael Newton 2011-11-14 19:07:45 UTC
I'll defer to any suggestions regarding ickiness, as I'm certainly not that experienced working with the Mediawiki code.

It's been a while so I don't recall why I did it this way, but my notes say that this implementation is "same as $wgLogActions or $wgHooks" so I believe I was just copying some existing code.
Comment 5 Michael Newton 2011-11-14 21:03:16 UTC
Created attachment 9450 [details]
updated patch for 1.17.0

For what it's worth, here's the patch updated to 1.17.0 code, with the above mentioned issues addressed. I don't have a trunk setup at the moment.
Comment 6 Bawolff (Brian Wolff) 2011-11-17 00:11:21 UTC
You can already do quite a lot of customization with $wgLogActionsHandlers. I'm not sure what circumstances you would need this (Don't want to display the timestamp for some reason?) [note: $wgLogActionsHandlers might be new-ish, so its possible it didn't exist when you wrote this]
Comment 7 Mark A. Hershberger 2011-11-17 00:45:34 UTC
not needed re: bawolff's comments, or rather FIXED!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links