Last modified: 2010-07-28 21:58:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26350, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24350 - Simplesearch breaks suggestions on vector when disabled
Simplesearch breaks suggestions on vector when disabled
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Adam Miller
:
: 23823 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-12 14:38 UTC by Nikola Kovacs
Modified: 2010-07-28 21:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nikola Kovacs 2010-07-12 14:38:31 UTC 
When the "Enable enhanced search suggestions (Vector skin only)" option is disabled, the suggestion dropdown doesn't appear. This is because the code in SimpleSearch.js runs regardless of the setting, and it activates the enhanced search suggestions, but because the simpleSearch div is missing from the output, the suggestion dropdown isn't positioned correctly and it is not visible.

If I'm not mistaken, this part:

if( !wgVectorEnabledModules.simplesearch || wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) {
  return true;
}

needs to also check for !wgVectorPreferences.simplesearch.enable
Comment 1 Roan Kattouw 2010-07-17 13:51:32 UTC 
*** Bug 23823 has been marked as a duplicate of this bug. ***
Comment 2 Roan Kattouw 2010-07-17 13:52:00 UTC 
(In reply to comment #0)
> If I'm not mistaken, this part:
> 
> if( !wgVectorEnabledModules.simplesearch ||
> wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) {
>   return true;
> }
> 
> needs to also check for !wgVectorPreferences.simplesearch.enable
This looks like it's the culprit; Adam, could you handle this?
Comment 3 Adam Miller 2010-07-28 21:58:30 UTC 
i added it...r70117. Not sure it was needed, but it also doesn't seem to break anything.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links