Last modified: 2013-04-08 17:57:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26335, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 24335 - check wgEnableAPI before use the api


Summary:	check wgEnableAPI before use the api

Status:	RESOLVED WONTFIX

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	UsabilityInitiative (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Lowest enhancement (vote)
Target Milestone:	---
Assigned To:	Roan Kattouw

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-07-10 20:16 UTC by Umherirrender
Modified:	2013-04-08 17:57 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2010-07-10 20:16:03 UTC

Please check the js var wgEnableAPI before use the api. Because the api can be disabled (temporarily) by server admins.

Thanks.

Comment 1 Andre Klapper 2013-04-07 21:01:48 UTC

Hi Umherirrender,
which exact API does this refer to nowadays? WikiEditor? Could you provide a pointer to the place in the codebase?

Comment 2 Kevin Israel (PleaseStand) 2013-04-07 21:45:09 UTC

Andre: wgEnableAPI is for the web API (/w/api.php). See bug 30213.

I'm marking this RESOLVED WONTFIX because the UsabilityInitiative extension is obsolete, having been split up quite a while ago (the surviving portions became the Vector and WikiEditor extensions).

https://www.mediawiki.org/wiki/Extension:UsabilityInitiative

Also, as noted on bug 30213, the $wgEnableAPI config setting should probably just be eliminated (and the API permanently enabled).

Comment 3 Umherirrender 2013-04-08 17:52:22 UTC

(In reply to comment #1)
> Hi Umherirrender,
which exact API does this refer to nowadays? WikiEditor?
> Could you provide a
pointer to the place in the codebase?

In theroy all ajax calls from the MediaWiki GUI like action=watch. But that is never checked, so killing this is also a valid option. The api is stable (from a performance point of view) and when there are problems, now the corrosponding api module is disabled and not the whole api. So WONTFIX is okay.

Comment 4 Max Semenik 2013-04-08 17:57:02 UTC

Disabling the API just breaks the hell out of a lot of UI stuff, so instead of honoring that variable we indeed should work towards removing it.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links