Last modified: 2010-07-15 19:59:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 24282 - SimpleSearch highlight changes suggestions
SimpleSearch highlight changes suggestions
Status: RESOLVED DUPLICATE of bug 24237
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Adam Miller
Depends on:
  Show dependency treegraph
Reported: 2010-07-06 10:41 UTC by Derk-Jan Hartman
Modified: 2010-07-15 19:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Derk-Jan Hartman 2010-07-06 10:41:12 UTC
"When I search for certain items, it seems that the search bar brings up strange results. For instance, searching "Doctor Who (" turns the "(" into an "a" ([ an example here in this segment of a screen cap]) and a search for "Doctor Who h" turns the "h" into an ":" (i'm using Doctor Who examples because that's what I was indeed looking for when I discovered this). I get the bug with other searches (like, "Star Trek o") or when I search for a single word and a space (like "Star " turns "Starting Pitcher" into "Star ing Pitcher" and "Starbucks" into "Star ucks" and "Life " turns "Life Imprisonment" into "Lifebimprisonment"). In fact, I just noticed this now, but searching for "life" then two spaces turns the searches into "Lifebo+(rest of search result phrase beginning with "Life"), three spaces turns the search to "Lifeboa+(rest of search result phrase beginning with "Life"), eg "Lifeboaimprisonment", and so on until "Life+17 spaces" full reveals "Lifeboat (shipboard)" over the search results. I get the same thing if I search words like "time", "star", "rose" and "royal" and a bunch of spaces or any spaces (even sometimes one)."

This is confirmed with Internet Explorer 6 and 7, Firefox 3.3.6 and 3.3.7.
Proactively assigning this to adam, who implemented this as far as I know.
Comment 1 Derk-Jan Hartman 2010-07-06 10:51:32 UTC
Oh important note, the isssue does NOT show in Chrome/Safari.
Comment 2 Steef 2010-07-10 19:04:27 UTC
It seems to me (I don't know the code) that the search engine ignores some characters, for example leading and following spaces and brackets. But the highlighting doesn't do so.

Example (dewiki):
If you enter " sinus ", you get
 Sinus cnd Kosinus
 Sinus cis
 Sinus caroticus
 Sinus cavernosus
instead of
 Sinus und Kosinus
 Sinus caroticus
 Sinus cavernosus

If you add an additional space, every suggestion starts with "Sinus cav".

So I think, the highlighting in Javascript (it isn't in the Ajax-answer) takes the number of charakters of the search input and uses so much characters of the last suggestion and puts them bold in front of the results.

And this isn't a browser issue: It is also wrong in Chrome and Opera (I didn't test safari, but think it is the same there). This error only occurs in Vector-Skin, because in Monobook, the results are not highlighted bold.

Trimming the same Characters at the back and front in the Javascript function which are trimmed in the search engine should resolve this issue.
Comment 3 db [inactive,noenotif] 2010-07-10 20:55:03 UTC
An other issue (IE8, FF3.6):

Searching for "rev" on dewiki:

* REVolution
* ...
* REVolver

The highlighting has the upper case from the last entry for all entries. Same for "mac".
Comment 4 Roan Kattouw 2010-07-15 19:59:00 UTC

*** This bug has been marked as a duplicate of bug 24237 ***

Note You need to log in before you can comment on or make changes to this bug.