Last modified: 2014-09-24 01:28:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26263, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24263 - Blank lines aren't displayed well in diff
Blank lines aren't displayed well in diff
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.17.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-05 06:17 UTC by Liangent
Modified: 2014-09-24 01:28 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (7.83 KB, image/png)
2011-10-08 03:09 UTC, Liangent
Details

Description Liangent 2010-07-05 06:17:54 UTC
http://zh.wikipedia.org/w/index.php?title=Template:DYKEntry&diff=prev&oldid=13625486

This may make people confused?
Comment 1 Sumana Harihareswara 2011-10-07 22:18:25 UTC
Liangent, this looks fine to me (with MediaWiki 1.18).  If you're still seeing a problem, please reopen and attach a screenshot so we can see what looks confusing.  Thanks!
Comment 2 Liangent 2011-10-08 03:09:19 UTC
Created attachment 9190 [details]
screenshot

The attachment is what I see.

The actual change is "{{#if:{{{image|}}}|[[File:{{{image}}}|right|80px]]}}" and a blank line was swapped. But the blank line is not shown in diff as a "line" so users may think two lines with contents are simply misaligned... so what's the real change in this edit?
Comment 3 Liangent 2011-10-08 03:13:04 UTC
Or display it in this way:

  <includeonly>                                        |  <includeonly>
                                                       |+ 
  {{#if:{{{image|}}}|[[File:{{{image}}}|right|80px]]}} | {{#if:{{{image|}}}|[[File:{{{image}}}|right|80px]]}}
-                                                      |
  * {{{question|}}}                                    | * {{{question|}}}

ie. The blank line is changing and the {{#if:{{{image|}}} line is not changing.
Comment 4 John Mark Vandenberg 2011-10-08 03:16:27 UTC
The diff should show an empty line being removed from the old revision and an empty line being added to the new revision.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links