Last modified: 2013-03-06 15:03:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26237, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24237 - SimpleSearch Suggestions match highlighting broken
SimpleSearch Suggestions match highlighting broken
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 24226 24233 24282 24329 24390 (view as bug list)
Depends on:
Blocks: 27411
  Show dependency treegraph
 
Reported: 2010-07-02 17:30 UTC by howief
Modified: 2013-03-06 15:03 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description howief 2010-07-02 17:30:14 UTC
Please see: http://meta.wikimedia.org/wiki/2010_Wikimedia_design_and_feature_change/Bug_reports#Search_works_incorrectly_with_brackets_and_hyphen

Search suggestions are displayed incorrectly, though the links appear to work properly.  The following is copied from the report on meta:


Expected behavior
If one types some search query with brackets or hyphen, old search usually ignored these symbols and offered variants both with and without these symbols

Observed behavior
Also new search does ignore these symbols, suggestions are displayed incorrectly. All of them tend to have the same symbol on the place of a bracket or a hyphen, which may be different for different suggestions. For example, Динамо Київ was typed on screenshot 1, the bottom variant really is Динамо Київ (журнал), although the top one is different, it is Динамо (Київ), incorrectly displayed as Динамо Київв). Same for screenshot 2, all links but the bottom one begin with Динамо (с, the bottom one begins with Динамо-С, and this variant is copied for other variants. However, links are correct

Steps to reproduce
Type any search query where some of the suggestions have brackets and/or hyphen and some not

Here are direct links to screenshots:
http://meta.wikimedia.org/wiki/File:VectorSearchBug1.jpg
http://meta.wikimedia.org/wiki/File:VectorSearchBug2.jpg
Comment 1 Roan Kattouw 2010-07-14 17:56:56 UTC
Simpler test case (dot versus space) reported at http://en.wikipedia.org/wiki/Wikipedia:VPL#Vector_search_dot_.28._period.29_suggestions .

This is a weird one. I've looked at the JSON returned from opensearch and that data is correct. Something in our suggestions plugin is rewriting these things somehow.
Comment 2 Roan Kattouw 2010-07-15 19:57:45 UTC
*** Bug 24390 has been marked as a duplicate of this bug. ***
Comment 3 Roan Kattouw 2010-07-15 19:58:26 UTC
*** Bug 24329 has been marked as a duplicate of this bug. ***
Comment 4 Roan Kattouw 2010-07-15 19:59:00 UTC
*** Bug 24282 has been marked as a duplicate of this bug. ***
Comment 5 Roan Kattouw 2010-07-15 20:03:15 UTC
For more interesting examples, look no further than the duplicates listed above.
Comment 6 Roan Kattouw 2010-07-15 20:03:27 UTC
*** Bug 24233 has been marked as a duplicate of this bug. ***
Comment 7 Roan Kattouw 2010-07-15 20:03:49 UTC
*** Bug 24226 has been marked as a duplicate of this bug. ***
Comment 8 Matt Nash 2010-07-15 20:15:51 UTC
Introduction of a comma also changes results, but a non-alpha character isn't necessary.  Try "Springfield I" and "Springfield, I" for an example of this behavior.
Comment 9 Derk-Jan Hartman 2010-07-16 01:33:45 UTC
Got it. the problem is in jquery.suggestions.js

within configure, case suggestions:

autoEllipsis() gets passed "matchedText". matchedText is always the text of the last suggestion in the list, with the substr length of context.data.prevText.length. So for "Doctor Who (" the last suggestion is "Doctor Who and the Silurians" and the matched text that is passed to autoellipsis  is "Doctor Who a". If you add a breakpoint, you can actually see that during the building of the list of suggestions, "matchedText" is continuously updated to the last processed suggestion.
Comment 10 Adam Miller 2010-07-16 16:33:03 UTC
I have this fixed and have asked Roan and/or Trevor to review and deploy it. Waiting on them. Sorry I didn't see this bug earlier to update you all.
Comment 11 Derk-Jan Hartman 2010-07-28 23:12:20 UTC
Ok, it's a lot better now. But try this:

"Doctor Who (TV series"

result

<b>Doctor Who</b> (TV <b>series</b>
Comment 12 Derk-Jan Hartman 2010-10-18 09:44:57 UTC
This last issue still exist.
Comment 13 Thehelpfulone 2012-06-22 19:45:22 UTC
Reassign to default per bug 37789
Comment 14 Andre Klapper 2013-03-06 15:03:58 UTC
I cannot reproduce any of the problems listed here with the Search on en.wikipedia.org, uk.wikipedia.org or sv.wikipedia.org.

I assume this has been fixed in the meantime, but please reopen this ticket and provide an example and an URL where to still see this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links