Last modified: 2010-06-28 17:53:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26155, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24155 - Import produces errors with php 5.2 and before.
Import produces errors with php 5.2 and before.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-28 12:24 UTC by David Severwright
Modified: 2010-06-28 17:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
func_get_args_fix-r68654.patch (1.38 KB, patch)
2010-06-28 12:24 UTC, David Severwright 		Details
Add an attachment (proposed patch, testcase, etc.)

Description David Severwright 2010-06-28 12:24:25 UTC 
Created attachment 7519 [details]
func_get_args_fix-r68654.patch

Using r68654 and php 5.2.13 attempting to import an XML file via Special:Import produces the following error:
Fatal error: func_get_args(): Can't be used as a function parameter in .../includes/ImportXMLReader.php on line 216

Using func_get_args directly a function parameter is only possible in php 5.3 and above, see http://php.net/manual/en/function.func-get-args.php

The attached patch fixes this problem.
Comment 1 Roan Kattouw 2010-06-28 16:19:51 UTC 
Assigning to Andrew as I suspect his recent rewrite of the import/export code introduced this bug.
Comment 2 Alexandre Emsenhuber [IAlex] 2010-06-28 17:53:19 UTC 
Fixed in r68670.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links