Last modified: 2011-05-15 09:55:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26132, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24132 - dumpBackup.php should warn if $wgDBAdmin* not set (patch expands documentation)
dumpBackup.php should warn if $wgDBAdmin* not set (patch expands documentation)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.15.x
All All
: Normal normal (vote)
: ---
Assigned To: Chad H.
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-26 21:47 UTC by Jonathan Wiltshire
Modified: 2011-05-15 09:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
expand documentation (1.07 KB, patch)
2010-06-26 21:47 UTC, Jonathan Wiltshire
Details

Description Jonathan Wiltshire 2010-06-26 21:47:23 UTC
Hi,

The attached patch (for 1.15.4, but should fit 1.16 fairly easily) expands the documentation for maintenance/dumpBackup.php.

Notably, it also hints to the administrator that --conf can be used to specify the patch to LocalSettings.php if it's somewhere unexpected, instead of just crying and running away.

However, dumpBackup.php script still fails magnificently if $wgDBadmin.. are not set. It should warn and fall back on $wgDB.., since that'll probably be sufficient in most hosting environments.
Comment 1 Jonathan Wiltshire 2010-06-26 21:47:55 UTC
Created attachment 7517 [details]
expand documentation
Comment 2 Sam Reed (reedy) 2010-11-04 02:02:20 UTC
Manually applied patch to what was commandLine.inc in r75975

For the dumpBackup stuff... As of SVN head, pagelist has already been added...

  --pagelist=<file>
              Where <file> is a list of page titles to be dumped


I think admin conf is now deprecated...? If someone else can confirm/deny, I'll apply the rest of the patch


Thanks!
Comment 3 Sam Reed (reedy) 2010-11-04 02:03:16 UTC
Yeah, it was... http://www.mediawiki.org/wiki/Manual:AdminSettings.php
Comment 4 Sam Reed (reedy) 2010-11-04 02:05:31 UTC
r75976


Just the
"However, dumpBackup.php script still fails magnificently if $wgDBadmin.. are
not set. It should warn and fall back on $wgDB.., since that'll probably be
sufficient in most hosting environments." to deal with
Comment 5 Chad H. 2011-05-04 15:44:36 UTC
(In reply to comment #0)
> However, dumpBackup.php script still fails magnificently if $wgDBadmin.. are
> not set. It should warn and fall back on $wgDB.., since that'll probably be
> sufficient in most hosting environments.

I'm pretty sure this isn't true anymore since the maintenance rewrite.
Comment 6 Chad H. 2011-05-13 14:58:45 UTC
Closing as FIXED, since the original doc expansion was done as requested. Per my earlier comment, I'm not truly sure that $wgDBadmin* needs to be set anymore.

Feel free to reopen if you can show this to still be an issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links