Last modified: 2010-06-24 19:45:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26115, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24115 - API login NeedsToken response should provide a sessionid
API login NeedsToken response should provide a sessionid
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-24 17:22 UTC by Robert Leverington
Modified: 2010-06-24 19:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Robert Leverington 2010-06-24 17:22:44 UTC 
The API NeedsToken response to login actions should provide a sessionid attribute in the same was that the Success response does.
Comment 1 Sam Reed (reedy) 2010-06-24 19:29:09 UTC 
			case LoginForm::NEED_TOKEN:
				global $wgCookiePrefix;
				$result['result'] = 'NeedToken';
				$result['token'] = $loginForm->getLoginToken();
				$result['cookieprefix'] = $wgCookiePrefix;
				$result['sessionid'] = session_id();
				break;

It does in trunk, but doesn't in 1.16

http://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.16wmf4/includes/api/ApiLogin.php?view=markup

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiLogin.php?view=markup
Comment 2 Bryan Tong Minh 2010-06-24 19:31:22 UTC 
We should backport that; it breaks clients that do not support extracting cookies from response headers I think.
Comment 3 Sam Reed (reedy) 2010-06-24 19:32:39 UTC 
It's in 1.16, probably needs putting into 1.15

It's in wmf3, but not wmf4 :/
Comment 4 Robert Leverington 2010-06-24 19:45:23 UTC 
Sorry, I did not check trunk - just the documentation and 1.16.

I have added it to [[API:Login]], if this is backported it will need updating though.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links