Last modified: 2010-08-08 06:03:21 UTC
Created attachment 7505 [details] Patch for sending UDP on comments and change status Right now the robot codurr in #mediawiki echos new comments on revisions. It does this with database queries which is slow and inefficient. This patch sends out an UDP packet like for Recent Changes as soon as the comment is posted or the status is changed. The variable for the UDP Address/Port/Prefix is separate than the one for RC.
Created attachment 7506 [details] Improved patch with proper usage of wfMsg and truncated comments
(In reply to comment #1) > Created an attachment (id=7506) [details] > Improved patch with proper usage of wfMsg and truncated comments +$wgCRUDPAddress = false; +$wgCRUDPPort = false; +$wgCRUDPPrefix = ''; I'd spell the CodeReview in full. Maybe also encapsulate the RecentChange::sendToUDP(...); line to keep those globals in one place only.
(In reply to comment #2) > I'd spell the CodeReview in full. Maybe also encapsulate the > RecentChange::sendToUDP(...); line to keep those globals in one place only. Sorry but what do you mean by "encapsulate the > RecentChange::sendToUDP(...); line", move it to its own function?
Yeah, I'd make a new function.
Created attachment 7513 [details] Patch version 3 This patch should address your requests. Let me know if it's missing anything.
r70660
keywords: s/need-review/reviewed/.