Last modified: 2012-03-27 16:43:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26082, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 24082 - Thread summary -> Link to -> Link URL isn't a URL, just a relative path


Summary:	Thread summary -> Link to -> Link URL isn't a URL, just a relative path

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	LiquidThreads (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-06-22 21:24 UTC by Ævar Arnfjörð Bjarmason
Modified:	2012-03-27 16:43 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ævar Arnfjörð Bjarmason 2010-06-22 21:24:10 UTC

The code that gets the "Link URL" in the "link to" popup window is:

        var linkURL = $j(this).attr('href');
        var linkTitle = $j(this).parent().find('input[name=summary-title]').val();
        liquidThreads.showLinkWindow( linkTitle, linkURL )

The problem is that href for that element is just a relative path, so I just get:

    /Summary:Spjall/D%C3%A6mi_um_spjall%C3%BEr%C3%A1%C3%B0

Surely that should be an absolute URL?

Comment 1 Ævar Arnfjörð Bjarmason 2010-06-22 21:26:30 UTC

Ah, clearly a bug at this page:

    http://liquidthreads.labs.wikimedia.org/wiki/Talk:Main_Page#Questions_arise_1786

Clicking "Link to" will get you a relative url, but More -> Link to an absolute one.

Comment 2 Nemo 2010-08-16 14:29:16 UTC

ANother problem with relative links in bug 23382.

Comment 3 Andrew Garrett 2010-08-28 13:22:07 UTC

Adding Adam to CC.

Comment 4 Helder 2012-03-27 16:43:04 UTC

On page
https://www.mediawiki.org/wiki/Thread:Extension_talk:LiquidThreads/Adding_toolbar_section_and_group_to_WikiEditor
after clicking "More" and then on "Link To" I got a popup containing the url above in the "Link URL" field.

So, I assume this was already fixed.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links