Last modified: 2014-03-09 18:04:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26074, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24074 - UserLogin with returnto doesn't preserve GET attributes
UserLogin with returnto doesn't preserve GET attributes
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.16.x
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-22 17:49 UTC by Lee Worden
Modified: 2014-03-09 18:04 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lee Worden 2010-06-22 17:49:53 UTC
Here's an example:

I'm working on a private wiki that isn't readable to anonymous users.  I make a change and send it to a collaborator:
http://xxx.yyy/wiki/index.php?title=Page&diff=3275&oldid=2643

My collaborator's login has expired so he gets the UserLogin page.  Once he's logged in, he is redirected to "Page" but not to the diff information, because those arguments were thrown away when he got redirected to UserLogin.

This happens to links to special pages, etc. as well.  It's probably a bit troublesome to fix, but should be possible.
Comment 1 Roan Kattouw 2010-06-22 17:51:14 UTC
I fixed this in trunk myself many months ago, and it works on Wikipedia.
Comment 2 Liangent 2010-06-22 17:55:08 UTC
The log in link at top right corner includes returntoquery parameter.

But the log in link in page content doesn't.
Comment 3 Krinkle 2010-06-22 17:56:07 UTC
@Lee Worden: if this is not on a wiki-site from Wikimedia, but one of your own, make sure you're up2date.

Go to [[Special:Version]] on your private and report the versionumber after: MediaWiki:
Comment 4 Krinkle 2010-06-22 18:03:50 UTC
The message being displayed: "You must log in to view other pages."

The "log in " does have returnto= but not returntoquery=

Also when on a page with a query and logging out there are two more links that don't have the returntoquery=.

Namelely the {[following]} two:

1) = Log out =
You are now logged out.
You can continue to use SITENAME anonymously, or you can [{log in}] again.

2) #pt-login [{Log in / create account}]
Comment 5 Lee Worden 2010-06-22 18:05:05 UTC
Yes, I have just updated and reconfirmed this behavior on a private wiki
running r68409 of http://svn.wikimedia.org/svnroot/mediawiki/trunk/phase3.
Special:Version reports '1.17alpha'.

I have been using the "log in" link in the page text, not the small one at the
upper right (Monobook skin).
Comment 6 Bryan Tong Minh 2010-10-24 15:09:15 UTC
If this link is generated from the wiki text [[Special:UserLogin]] then it is not going to include the query string. It will simply go to Special:UserLogin as requested.
Comment 7 Liangent 2010-10-25 01:43:35 UTC
It's not generated from the wiki text [[Special:UserLogin]].

Even if it is, since it's in an interface message, we can change the wiki text to avoid using [[Special:UserLogin]] directly.
Comment 8 Krinkle 2010-10-25 13:38:23 UTC
I believe the interface message for situation 1 described in my earlier comment is: "MediaWiki:Logouttext"

(See also: http://translatewiki.net/wiki/MediaWiki:Logouttext/en )

The link there could be replaces by $1 and the software would replace it with a link to Special:UserLogin preserving returnto and returntoquery.

I'm don't know exactly the origin of the link in situation 2 (the link in #pt-login) though.
Comment 9 Liangent 2010-10-25 13:48:26 UTC
(In reply to comment #8)
> I'm don't know exactly the origin of the link in situation 2 (the link in
> #pt-login) though.

The link in #pt-login doesn't have this bug.
Comment 10 Bawolff (Brian Wolff) 2010-10-25 17:58:55 UTC

>in regards to mediawiki:logouttext

Personally it seems a little weird to preserve the query parameters in the "You have successfully logged out" message because if they hit the "log in again" button, they have now done something else, so once they have re-logged in the previous action they did was not the page with the query parameters we saved from two actions ago. But maybe that is just me.


The original bug seems to be referring to the message given on private wikis (Aka read restricted to logged in users) when you try to view a page not logged in. Specifically [[mediawiki:loginreqpagetext]] which is output by OutputPage::loginToUse. That should be straight forward to fix.
Comment 11 Krinkle 2010-10-25 19:13:59 UTC
(In reply to comment #10)
> 
> >in regards to mediawiki:logouttext
> 
> Personally it seems a little weird to preserve the query parameters in the "You
> have successfully logged out" message

On second thought, I agree with you. Also because this could leak potential information.
Imagine someone is browsing stuff, when the user logs out I think it is a reasonable expectation that other then the browser-history (which is something that can be disabled) there are no obvious traces left of what one did. So that someone else can now login without directly knowing what the previous user did.
Comment 12 db [inactive,noenotif] 2013-03-16 23:14:57 UTC
Login link to logouttext was added with bug 23222

loginreqpagetext has also a login link since the begin (r10379)
Comment 13 Bartosz Dziewoński 2014-02-20 00:17:22 UTC
I think I fixed this for good a couple months ago with I43ceaddb.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links