Last modified: 2010-06-11 18:29:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25897, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23897 - WikiEditor has empty divs with styling
WikiEditor has empty divs with styling
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-11 00:33 UTC by Derk-Jan Hartman
Modified: 2010-06-11 18:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2010-06-11 00:33:47 UTC
The wikiEditor has several <div style="clear:both;"></div> elements. This styling can easily be added to the existing styling of other div's without the need for an additional empty div.
Comment 1 Trevor Parscal 2010-06-11 18:29:30 UTC
We use this for 2 reasons. 1, to clear the floating so that elements later on which also use floating are reset to the far left/right. 2, to automatically size the parent container's height to the height of all floated elements within it.

Clear has to do with what the element does to the floating chaing *before* it's rendered, *not after*. Adding clear:both to the last element in a series of floating elements will result in that element breaking the floating chain and then being rendered at the far left/right below the other elements.

By using <div style="clear:both"></div> we can clear floating and get the parent container to receive the correct height.

I hope this clears this up.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links