Last modified: 2011-11-27 11:19:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25890, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23890 - Log: the usertoollinks are inside of mw-logevent-actionlink
Log: the usertoollinks are inside of mw-logevent-actionlink
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-10 19:27 UTC by Umherirrender
Modified: 2011-11-27 11:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Move the usertoollinks from $revert into the message (2.22 KB, patch)
2010-06-11 19:01 UTC, Umherirrender 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2010-06-10 19:27:07 UTC 
The logline of an account created by another has the usertoollinks inside the logevent-actionlink. This is bad when both classes are styled by user css.

The problem is, that $revert in LogEventsList.php is used for the usertoollink to place the toollink at the end of the log, with bug 16760 that variable was wrapped into a class.
Comment 1 Umherirrender 2010-06-10 19:36:22 UTC 
The wrong use of $revert were added in r40769.
Comment 2 Umherirrender 2010-06-11 19:01:24 UTC 
Created attachment 7463 [details]
Move the usertoollinks from $revert into the message
Comment 3 Sumana Harihareswara 2011-11-10 00:13:03 UTC 
+need-review
Comment 4 Sumana Harihareswara 2011-11-24 19:34:05 UTC 
Comment on attachment 7463 [details]
Move the usertoollinks from $revert into the message

Per automated testing
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html patch
no longer applies to MediaWiki trunk in Subversion.
Comment 5 Sumana Harihareswara 2011-11-24 19:35:26 UTC 
Umherirrender, I'm sorry for the wait in review.  The patch you wrote last year doesn't apply to trunk anymore.  Is this patch still needed?  If so, would you be interested in updating it?  Thanks, and sorry again.
Comment 6 Umherirrender 2011-11-27 11:19:26 UTC 
Looks fixed by the LogFormatter (re)write.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links