Last modified: 2012-09-27 01:11:09 UTC
It seems the lightgray label is somewhat bottom aligned. Some users have suggested that it probably should be mid aligned. Observed on FF, Safari and Chrome.
Suggest changing padding on simplesearch label to "padding: 0 0.25em" P.S. why is this css JS added ? It is present on almost ANY page loaded. If there is something that should probably be in the vector css, then it is this not ? Give me the word and i'll fix both.
Trevor or Adam, could one of you comment on this?
(In reply to comment #1) > Suggest changing padding on simplesearch label to "padding: 0 0.25em" > > P.S. why is this css JS added ? It is present on almost ANY page loaded. If > there is something that should probably be in the vector css, then it is this > not ? > > Give me the word and i'll fix both. No need to fix either. The CSS is added with JS because of the behavior the JS introduces. If JS is disabled we don't want the label rendered directly over the input field. I'm aware of the misalignment and have been working on a fix. The CSS which is positioning right now is causing it to be rendered inconsistently across browsers, so I'm working on a better solution.
If there is no JS, then the label is not added right ? In that case the CSS is unused, but that shouldn't be a problem.
Ah, you're correct. It's not added if JS is disabled. I was assuming that php was rendering the label, since I'm of the opinion that it should be there even if JS is disabled. I'll talk to Trevor (who I believe wrote this module) about it and see if he's got a good reason for the label being added with JS.
I've completed my work on this alignment biz. Pertinent revs are r68109, r68108, r67871, and r67872.
