Last modified: 2012-06-26 05:32:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 23866 - Shift enter in SimpleSearch opens results in original window AND tab
Shift enter in SimpleSearch opens results in original window AND tab
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-09 18:25 UTC by Derk-Jan Hartman
Modified: 2012-06-26 05:32 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2010-06-09 18:25:08 UTC
"Shift-Enter in Opera, which opens results in new tab, however in Vector the old tab goes to the results page as well."
Comment 1 Adam Miller 2010-06-09 18:57:30 UTC
Tested in 9.6 and 10.10 on Mac OS X 10.6.2. Can't replicate this behavior. Actually I can't get any combination of modifier keys to even open a google search in a new window in either version of Opera. Doesn't seem like there are preferences to enable/disable this behavior either. 

Feel free to reopen with more specifics about how to recreate this. I'll try it in Opera on windows next time I have a chance just to be sure.
Comment 2 AlexSm 2010-06-10 18:11:07 UTC
Shift-Enter in the input field does work in Opera (at least on Windows), opening results in a new tab (same as shift-clicking submit button). It also works on google.com with JS disabled (Google also messing up with JS, just like WP).

As of today, on 1.16wmf4 (r66620), behaviour is different: Shift-Enter works as Enter (Shift is ignored), however Shift-clicking the "zooming glass" button works, opening results in new tab.

I was the person  who reported this on enwiki tech village, and although this will probably be wontfixed, I wanted to clarify.
Comment 3 AlexSm 2010-07-16 17:45:14 UTC
Update: right now I'm using the following personal .js code:

$j(function(){
 $j('#searchform').bind('keyup keydown mousedown', 
   function (e){ $j(this).attr('target', e.shiftKey?'_blank':'')})
})

Works perfectly in major browsers, also works with shift-click on suggestion list. I'm considering adding this to Vector.js on my home WM wiki because it seems very useful.

Closing as WORKSFORME, unless somebody is willing to add this feature to MediaWiki.
Comment 4 Roan Kattouw 2010-07-17 13:43:22 UTC
(In reply to comment #3)
> Update: right now I'm using the following personal .js code:
> 
> $j(function(){
>  $j('#searchform').bind('keyup keydown mousedown', 
>    function (e){ $j(this).attr('target', e.shiftKey?'_blank':'')})
> })
> 
> Works perfectly in major browsers, also works with shift-click on suggestion
> list. I'm considering adding this to Vector.js on my home WM wiki because it
> seems very useful.
> 
> Closing as WORKSFORME, unless somebody is willing to add this feature to
> MediaWiki.

I don't see why we couldn't add this JS to MediaWiki. We'll probably want to check for Ctrl (Firefox on Windows/Linux) and Command (Firefox on Mac) as well.
Comment 5 Thehelpfulone 2012-06-22 19:45:15 UTC
Reassign to default per bug 37789
Comment 6 badon 2012-06-23 02:28:51 UTC
I'm an long-time Opera user, and I believe this bug was actually a problem in an old version of Opera. As far as I have been able to test, I have not been able to duplicate this bug. However, there is a similar bug in Vector that affects all browsers, reported in bug 34756. It causes the loss of work while editing.

If no one is still concerned about this bug, I think it should be closed as fixed, worksforme, or wontfix.
Comment 7 badon 2012-06-26 05:32:39 UTC
I tested this again with the new Opera 12.00 and this bug seems to no longer exist. Note that I never duplicated this bug with any version I tried, from about version 11.54 to 12.00, which are newer than the versions in use at the time the bug was reported. Somebody somewhere must have fixed the bug, so I'll close it now as FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links