Last modified: 2012-05-20 06:35:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25844, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23844 - move js-var dataCacheTime
move js-var dataCacheTime
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-08 18:16 UTC by Umherirrender
Modified: 2012-05-20 06:35 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2010-06-08 18:16:52 UTC 
In QueryPage.php the javascript variable "dataCacheTime" is added to the special page. Move the variable to the other variable in Output, because there is no need for a extra script-tag. Thanks.
Comment 1 Brion Vibber 2010-12-27 04:00:06 UTC 
There's not really a good place to put it; the classic 'js vars' block is global (Skin::makeGlobalVariablesScript) and awkward to extend internally, and there don't seem to be other querypage-specific script areas to merge it into.

Since the inline <script> doesn't appear to harm anything either, it's probably not worth worrying about at this stage. If interfaces on OutputPage change in future in a way that would make this super-easy to move into a nice big block, then reopen/implement.
Comment 2 Chad H. 2011-11-29 20:14:30 UTC 
Is this thing actually used anywhere? I can't find any uses in trunk or extensions or searching enwiki. I would just be inclined to remove it.
Comment 3 Umherirrender 2012-05-19 17:44:44 UTC 
Gerrit change #8019
Comment 4 Umherirrender 2012-05-20 06:35:28 UTC 
successfully merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links