Last modified: 2014-10-07 06:18:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25806, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23806 - Upload warning "non-descriptive name" too strict
Upload warning "non-descriptive name" too strict
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-05 16:23 UTC by Subfader
Modified: 2014-10-07 06:18 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Subfader 2010-06-05 16:23:26 UTC
The following warning appears when you use IMG etc in teh beginnging of a file name on Special:Upload

The name of the file you are uploading begins with "[IMG / JD etc]", which is a non-descriptive name typically assigned automatically by digital cameras. Please choose a more descriptive name for your file.

No it appears whenever [IMG / JD etc] is used in the filename, no matter what the rest of the filename looks like:

For instance "JD - Very unique text.gif" shouldn't return the warning as IMG / JD etc can also be an abbreviation for whatever.
Comment 1 Betacommand 2010-06-05 16:27:28 UTC
Is this on a WMF wiki or where is this?
Comment 2 Subfader 2010-06-05 18:35:46 UTC
it's MediaWiki so all wiki's are affected :P
Comment 3 Betacommand 2010-06-05 18:40:19 UTC
that may not be the case, most of these restrictions are put into place via the title blacklist of the local wiki, which is why I asked the question, so PLEASE answer the question.
Comment 4 Platonides 2010-06-05 18:44:06 UTC
Can't reproduce. The code does check the beginning if ( substr( $partname, 0, strlen( $prefix ) ) == $prefix ) {, UploadBase.php:1126 and I can upload files with CIMG at the middle without the warning being shown http://test.wikipedia.org/wiki/File:12_CIMG_34.png
Comment 5 Subfader 2010-06-05 18:45:10 UTC
Tested and confirmed for the beginning of titles on my own wiki and mediawiki.org.
Comment 6 Platonides 2010-06-05 19:51:41 UTC
Yes, it shows the warning then it's at the beginning. But not when it's in the middle. Thus as expected.
Comment 7 MZMcBride 2010-06-05 20:03:10 UTC
I don't understand why a warning is a bad thing here. False positives are rare and there is an optional override for the warning. Suggest WONTFIX or INVALID.
Comment 8 Bryan Tong Minh 2010-06-05 20:04:39 UTC
Perhaps we should change the blacklist to only trigger if the prefixes are followed by a number.
Comment 9 Subfader 2010-06-05 20:30:41 UTC
I didn't say it's too bad, just not proper. If my title reads "JD - Very unique text.jpg", the uploader shouldn't tell me to "choose a more descriptive name".

Maybe if followed by numbers or only a few characters?
Comment 10 Krinkle 2010-06-05 20:42:57 UTC
Just to note here, I've seen cameras with filenames like "IMGX-001" too. So solely numerical numbers after "IMG" wouldn't improve the warn function.
Comment 11 Bryan Tong Minh 2010-06-18 15:03:40 UTC
(In reply to comment #10)
> Just to note here, I've seen cameras with filenames like "IMGX-001" too. So
> solely numerical numbers after "IMG" wouldn't improve the warn function.
How about beginning with IMG and any sequence of 3 consecutive numbers?
Comment 12 Platonides 2010-06-18 15:08:41 UTC
Perhaps it may make sense to restrict the check to filenames no longer than 12 characters, since all cameras are conforming to 8.3.

However, any change we make, will break some usages IMHO.
Comment 13 Marco 2014-05-31 17:56:35 UTC
15 *additional* characters should be enough to describe a file. 

Change-Id: I3851b2e34571dc44706408a425541b9395aa4793

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links