Last modified: 2010-07-21 11:25:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25744, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23744 - Improve persistence of CollapsibleNav, toolbar section state
Improve persistence of CollapsibleNav, toolbar section state
Status: RESOLVED DUPLICATE of bug 24140
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
: 23628 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-01 13:49 UTC by Roan Kattouw
Modified: 2010-07-21 11:25 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2010-06-01 13:49:56 UTC
We currently store these states in cookies that expire when the session ends. This means the state is lost rather often for most users.

An easy solution is to set the cookies' expiry far into the future (say, 30 days) and renew this expiry date every time.

A better solution would be to store this data in the preferences table for logged-in users. This would ensure it never expires and carries over between logins on different computers.
Comment 1 Roan Kattouw 2010-06-04 18:43:23 UTC
(In reply to comment #0)
> We currently store these states in cookies that expire when the session ends.
> This means the state is lost rather often for most users.
> 
> An easy solution is to set the cookies' expiry far into the future (say, 30
> days) and renew this expiry date every time.
> 
Did this in r67204, as well as making the cookies domain-wide (rather than having separate cookies for /wiki and /w/index.php) in r67354. Both have been deployed.

> A better solution would be to store this data in the preferences table for
> logged-in users. This would ensure it never expires and carries over between
> logins on different computers.
On second thought, I think this is a bad idea.
Comment 2 Roan Kattouw 2010-06-07 11:18:39 UTC
*** Bug 23628 has been marked as a duplicate of this bug. ***
Comment 3 Marco 27 2010-06-11 10:49:27 UTC
Since the interwiki section has been set to be opened by default, the cookie doesn't affect the state of that section (instead it affects the one of the other sections).
For instance, when a user closes the interwiki section and opens another page, that section will always be opened (unlike the others).
Comment 4 Roan Kattouw 2010-06-11 19:09:13 UTC
(In reply to comment #3)
> Since the interwiki section has been set to be opened by default, the cookie
> doesn't affect the state of that section (instead it affects the one of the
> other sections).
> For instance, when a user closes the interwiki section and opens another page,
> that section will always be opened (unlike the others).

Could you explain what you mean more clearly? I don't quite understand the bug you're talking about here.
Comment 5 Marco 27 2010-06-11 21:05:19 UTC
Sure. Before showing interwiki section opened by default, the cookie remembered the choice of the specific user (if he opened a section, it'll be opened next time too, if he closed that one it'll be closed next time too).
Now, this works for all the sections, except for the interwiki one. In fact, if a user close it, it'll always be opened (but for this bug, it would have to be closed!).
Some users on it.wiki have reported the problem.
I hope I've explained it clearly.
Comment 6 Roan Kattouw 2010-07-21 11:25:14 UTC

*** This bug has been marked as a duplicate of bug 24140 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links