Last modified: 2010-05-28 21:24:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25699, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23699 - wrapWikiMsg can produce invalid html
wrapWikiMsg can produce invalid html
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-28 17:23 UTC by Umherirrender
Modified: 2010-05-28 21:24 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
untested patch for wrapWikiMsg in trunk (20.24 KB, patch)
2010-05-28 21:03 UTC, Umherirrender
Details

Description Umherirrender 2010-05-28 17:23:31 UTC
The most use of wrapWikiMsg is "<div class='mw-history-legend'>\n$1</div>", but it is better to also add a newline behind $1.

The problem is, when the wrap message use a list at the end, the closing div is added to the last item of this list. But the parser closed the list behind the div, so the ol and div are in the wrong order.

On normal wikipages, HTML Tidy is correted this, but for system message HTML Tidy is not used (expensive).

Example Wikitext:

Text
* item
* item

is wrapped:

<div class='mw-history-legend'>
Text
* item
* item</div>

ParserOutput:

<div class="mw-history-legend">
<p>Text
</p>
<ul><li> item
</li><li> item</div>
</li></ul>
Comment 1 Umherirrender 2010-05-28 21:03:42 UTC
Created attachment 7413 [details]
untested patch for wrapWikiMsg in trunk
Comment 2 Platonides 2010-05-28 21:24:56 UTC
Applied in r67029.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links