Last modified: 2010-07-09 00:17:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25695, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23695 - Allow &oldid= to work with Special:Undelete
Allow &oldid= to work with Special:Undelete
Status: RESOLVED DUPLICATE of bug 18104
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-28 11:04 UTC by FT2
Modified: 2010-07-09 00:17 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description FT2 2010-05-28 11:04:50 UTC
At present a deleted revision can be accessed by a page name + timestamp based link, but not by its revision id.

Most deleted revisions still have a revision id and an index now exists or will be imminently created on this field. The few old deleted revisions that don't have a revision id can easily be given one.

Revid/oldid is universally used everywhere else to identify a revision, except when it comes to deleted revisions. It would be a fairly simple change to allow links of the form: http://en.wikipedia.org/w/index.php?title=Special:Undelete&oldid=12345

to also work as an alternative to the existing URL style: http://en.wikipedia.org/w/index.php?title=Special:Undelete&target=PAGENAME&timestamp=TIMESTAMP


The advantages of allowing &oldid= to work as an identifier for deleted revisions would be that:

1/ If a revision is deleted or undeleted the revisionid stays the same so it can still be used to by admins to find the revision;

2/ Allows a fallback to be added to Mediawiki that if &oldid=12345 is given in a link, and the revision isn't in the current revisions table, it can easily and automatically be searched for in the deleted revisions table instead (or vice versa), so diff links will "dead end" less often.

3/ It's simple to do and probably trivial on effort (if Special:Undelete args include a page+timestamp look up the data by those, if the args are an oldid then look up the data by that in the same table);

4/ Makes it easier to transition in future to using rev_id as the common index field for revisions whether deleted or visible, which is a simplifying direction for Mediawiki. Right now everything is found by rev_id (whether visible, RevisionDeleted, oversighted, diff link, etc) with the sole exception of deleted revisions. This way Pagename/timestamp would still continue to work so it doesn't "break" anything or require a major rewrite, but allowing oldid to work as well makes the transition easier.
Comment 1 FT2 2010-05-28 11:13:05 UTC
This enhancement would also have useful effects on:

Bug 18104 - Schema request change so deleted edits are identified by revisionID not timestamp (prevents DIFFs from breaking)

Bug 18493 - Unify various deletion systems

Bug  21279 - Regular deletion of revisions deleted with rev_deleted breaks links in log entries
Comment 2 John Mark Vandenberg 2010-07-09 00:17:27 UTC

*** This bug has been marked as a duplicate of bug 18104 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links