Last modified: 2010-06-18 20:01:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25666, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23666 - FileRepo: Move File::isLocal() to FileRepo::isLocal()
FileRepo: Move File::isLocal() to FileRepo::isLocal()
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Bryan Tong Minh
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-05-25 17:53 UTC by Umherirrender
Modified: 2010-06-18 20:01 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch to move isLocal from File to FileRepo (1.11 KB, patch)
2010-05-25 17:55 UTC, Umherirrender 		Details
patch-2: add missing null check (1.17 KB, patch)
2010-05-25 20:39 UTC, Umherirrender 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2010-05-25 17:53:56 UTC 
It is useful to have a isLocal() method in FileRepo, to check easily, if a repo is the local repo.
Comment 1 Umherirrender 2010-05-25 17:55:03 UTC 
Created attachment 7406 [details]
patch to move isLocal from File to FileRepo

Thanks.
Comment 2 Chad H. 2010-05-25 18:06:16 UTC 
What's the use case for this? Where would you have a FileRepo object that you need to know local/non-local, but you're not already using some file?
Comment 3 Umherirrender 2010-05-25 20:09:34 UTC 
The method FileRepo::getDisplayName() can use this method.

With this method in FileRepo there is only one check of 'local' and not two hardcoded strings.
Comment 4 Umherirrender 2010-05-25 20:39:16 UTC 
Created attachment 7407 [details]
patch-2: add missing null check
Comment 5 Bryan Tong Minh 2010-06-18 20:01:02 UTC 
Fixed in r68235.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links