Last modified: 2014-02-12 23:38:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25657, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23657 - tag inconsistency
tag inconsistency
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-25 00:45 UTC by Ed
Modified: 2014-02-12 23:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed 2010-05-25 00:45:42 UTC
There seem to be some <p> tag inconsistencies in the code generated by semantic forms. E.g. in the code below the <p> and the <fieldset> tags are interweaved:


        <!-- start content -->
        <form name="createbox" onsubmit="return validate_all()" action="" method="post" class="createbox">
          <div id="wikiPreview" style="display: none; padding-bottom: 25px; margin-bottom: 25px; border-bottom: 1px solid #AAAAAA;"></div>
          <p>
          <fieldset>
            <legend>Enter event details</legend>
            <b>Date:</b> <span class="yui-skin-sam"><span id="input_2_container" style="position:absolute;display:inline;z-index:1000;margin-top:2em;"><span id="input_2_calendar"></span></span>
            <input type="text"  id="input_2" value="" class="createboxInput " style="vertical-align:middle;" name="Event_Input[1]" />
            <button tabindex="-1" type=button id="input_2_button" class="" onclick="toggle_datepicker(this);" style="height: 1.6em; width: 1.6em;vertical-align:middle;background-image: url(/mediawiki/extensions/SemanticFormsInputs/DatePickerButton.png);background-position: center center; background-repeat: no-repeat;" ></button>
            <span id="info_2" class="errorMessage"></span></span>
            </p>
            <p><b>Coordinates:</b>
              <input size="42" tabindex="3" id="map_google_coords_1_3" name="Event_Input[5]" />
              <span class="error_message" id="map_google_info_1_3"></span>
            <p>
              <input id="map_google_geocode_1_3" size="30" name="geocode" style="color: #707070" tabindex="4" value="Enter address here" onfocus="if (this.value=='Enter address here') {this.value='';}" onblur="if (this.value=='') {this.value='Enter address here';}" />
              <input onclick="showGAddress( document.forms['createbox'].map_google_geocode_1_3.value, 'map_google_1', 'map_google_coords_1_3', 'not found'); return false" type="submit" value="Look up coordinates" name="geosubmit" />
            </p>
            <div id="map_google_1" style="width: 665px; height: 350px; background-color: #cccccc; overflow: hidden;">Loading map...</div>
          </fieldset>
          </p>
          <p><br />
            <b>Free text:</b> </p>
          <p>
            <textarea tabindex="5" id="free_text" name="free_text" rows="10" cols="80" class="createboxInput"  ></textarea>
            <span id="info_4" class="errorMessage"></span> </p>
          <p><br />
            <span id='wpSummaryLabel'>
            <label for='wpSummary'>Summary:</label>
            </span>
            <input tabindex="6" type='text' value="" name='wpSummary' id='wpSummary' maxlength='200' size='60'/>
          </p>
          <p>
            <input tabindex="7" type="checkbox" value="1" name="wpMinoredit" accesskey="i" id="wpMinoredit"/>
            <label for="wpMinoredit" title="Mark this as a minor edit">This is a minor edit</label>
            <input tabindex="8" type="checkbox" name="wpWatchthis" accesskey="w" id='wpWatchthis'/>
            <label for="wpWatchthis" title="Add this page to your watchlist">Watch this page</label>
          </p>
          <p>
            <input id="wpSave" name="wpSave" type="submit" tabindex="9" value="Save page" accesskey="s" title="Save your changes" ="" />
            <input id="wpPreview" name="wpPreview" type="submit" tabindex="10" value="Show preview" accesskey="p" title="Preview your changes, please use this before saving!" ="" />
            <input id="wpDiff" name="wpDiff" type="submit" tabindex="11" value="Show changes" accesskey="v" title="Show which changes you made to the text" ="" />
            <span class='editHelp'><a href="javascript:history.go(-1);">Cancel</a></span> </p>
          <input type="hidden" value="20100525002646" name="wpStarttime" />
          <input type="hidden" value="20100524054721" name="wpEdittime" />
        </form>
Comment 1 Ed 2010-05-25 00:54:04 UTC
Here's the form that generated the above html.

<noinclude>
This is the "Event Input" form.
To create a page with this form, enter the page name below;
if a page with that name already exists, you will be sent to a form to edit that page.


{{#forminput:form=Event Input}}

</noinclude><includeonly>
<div id="wikiPreview" style="display: none; padding-bottom: 25px; margin-bottom: 25px; border-bottom: 1px solid #AAAAAA;"></div>
{{{for template|Event Input|label=Enter event details}}}
'''Date:''' {{{field|1|input type=datepicker|week start=1}}}

'''Coordinates:''' {{{field|5|input type=googlemaps}}}
{{{end template}}}


'''Free text:'''

{{{standard input|free text|rows=10}}}


{{{standard input|summary}}}

{{{standard input|minor edit}}} {{{standard input|watch}}}

{{{standard input|save}}} {{{standard input|preview}}} {{{standard input|changes}}} {{{standard input|cancel}}}
</includeonly>

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links