Last modified: 2011-04-30 01:21:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25526, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23526 - wikibits.js KHTML fix is applied for Epiphany 2.28 and destroys left menu (Monobook skin)
wikibits.js KHTML fix is applied for Epiphany 2.28 and destroys left menu (Mo...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.15.x
PC Linux
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-14 12:23 UTC by Jonas
Modified: 2011-04-30 01:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch for skins/common/wikibits.js (as explained in bug report) (187 bytes, patch)
2010-05-14 12:31 UTC, Jonas
Details

Description Jonas 2010-05-14 12:23:05 UTC
Using epiphany 2.28 on Ubuntu Karmic (uses webtoolkit) the browser is detected as KHTML browser. (which could be part true)
But the KHTMLfix.css file actually destroys the left menu for epiphany. It is moved to the bottom of the page.
Using the default CSS works like a charm. (so no css fixes are needed for this browser)

navigator.userAgent.toLowerCase() for this browser is:
mozilla/5.0 (x11; u; linux i686; en-us) applewebkit/531.2+ (khtml, like gecko) safari/531.2+

What I did to fix this (but this is only a suggestion, I could be missing something):

in wikibits.js

Line 11 (insert): 	var is_epiphany = clientPC.indexOf('applewebkit') != -1 && clientPC.indexOf('mozilla') != -1;

Line 108 (replace):     	} else if (is_khtml && !is_epiphany) {


Mind that older versions of epiphany could be using gecko renderer (I believe  v2.26 was available with both gecko and webkit) From 2.28 on they permanently chose to use webkit exclusively. Though I don't think this will cause problems with this fix.

I noticed this using Monobook skin, but this could probably occur on other skins as well.
Comment 1 Jonas 2010-05-14 12:31:25 UTC
Created attachment 7373 [details]
Proposed patch  for skins/common/wikibits.js (as explained in bug report)
Comment 2 Derk-Jan Hartman 2010-05-14 14:32:34 UTC
KHTMLFixes.css was already removed in r53141

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links