Last modified: 2014-04-26 13:49:04 UTC
"Has anyone else seen this behaviour with Vector? When editing an article, pressing Google Toolbar "Check" the text box changes to a light blue background as usual, but all of the text appears to be squashed into a line a few pixels high at the top of the edit box. Clicking still gives the menu to exit, so the spell seems to have loaded correctly. Using IE on XP" From: http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Google_toolbar_spell_check_not_working
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
(In reply to comment #0) > From: > http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Google_toolbar_spell_check_not_working Permanent link: http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=362277938
I am wondering if this bug is still happening. If anyone goto Internet Explorer + Google Toolbar, it would be great to attempt to reproduce the issue. Else, I guess we can close this bug report.
DJ: Any chance to retest this (in case you still use IE and Google Toolbar)? Wondering if this is a Vector or a WikiEditor issue nowadays. Trying WikiEditor. For the records, from https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=362277938#Google_toolbar_spell_check_not_working : Has anyone else seen this behaviour with Vector? When editing an article, pressing Google Toolbar "Check" the text box changes to a light blue background as usual, but all of the text appears to be squashed into a line a few pixels high at the top of the edit box. Clicking still gives the menu to exit, so the spell seems to have loaded correctly. Using IE on XP. welsh (talk) 19:58, 13 May 2010 (UTC) I fixed it by unchecking "Enable enhanced editing toolbar" in Preferences->Editing. welsh (talk) 21:18, 13 May 2010 (UTC) Logged as bugzilla:23518, but might just be an issue that Google has to fix, the developers will have to see what can be done.. —TheDJ (talk • contribs) 22:32, 13 May 2010 (UTC)
I tried this on a VM with Windows 7, IE10 + Google toolbar. On english wikipedia I get an error, on dutch wikipedia, i can reproduce it. This probably means that Google has hard blocked english wikipedia in the tool to prevent this bug. The toolbar replaces the textarea with some 'simple' tricks. of course for overly complex mediawiki, these tricks are way too simple. <span style="margin: 0px; padding: 1px; border: 0px rgb(0, 0, 0); top: 0px; width: 923px; height: 447px; text-align: left; color: black; overflow: auto; font-family: Courier New; font-size: 10pt; font-style: normal; font-weight: normal; display: inline-block; visibility: visible; background-color: rgb(232, 241, 255); dir: ltr;">{{Taxobox vlinder<br>| <span title="Klik hier voor suggesties" id="GTBSC_0" style="color: red; font-weight: bold; text-decoration: underline; cursor: pointer;">titelweergave</span> = ''Glyphipterix ... [the rest of the editbox content] </span> <textarea name="wpTextbox1" tabindex="1" id="wpTextbox1" accesskey="," lang="nl" style="overflow: hidden; visibility: hidden;" dir="ltr" rows="30" cols="120"> ... [editbox content] </textarea> The primary reason it goes all wrong is: .wikiEditor-ui .wikiEditor-ui-text { line-height: 0 }
Created attachment 13219 [details] Bug with squashed text contents in editor when using Google Toolbar
I think that that line-height: 0 style line was actually specifically for the iframe editing mode that we never deployed to production...
This might be fixed with https://gerrit.wikimedia.org/r/#/c/124607/
Created attachment 15217 [details] Screenshot of new situation-part1
Created attachment 15218 [details] Screenshot of new situation part2 When using google toolbar spellcheck, at least the text is visible now after the above patch. It's not nice and stuff (see the screenshots), but I don't think we should have to adapt our editor too much to something that google toolbar does. (Actually it appears as if en.wikipedia might be on some blacklist of this tool) I consider this working: 'good enough'. Any further problems are upstream issues as far as I'm concerned.
