Last modified: 2013-06-18 16:03:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25506, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 23506 - Upgrade to Java 1.5 / Cleaning up code


Summary:	Upgrade to Java 1.5 / Cleaning up code

Status:	RESOLVED INVALID

Product:	Utilities
Classification:	Unclassified
Component:	mwdumper (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Brion Vibber

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-05-13 14:18 UTC by Johannes Weberhofer
Modified:	2013-06-18 16:03 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Upgrade Java 1.5, further refactoring (86.54 KB, application/x-zip-compressed) 2010-05-13 14:18 UTC, Johannes Weberhofer	Details
Unzipped version of already attached patch (507.60 KB, patch) 2010-05-13 22:22 UTC, Sam Reed (reedy)	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Johannes Weberhofer 2010-05-13 14:18:39 UTC

Created attachment 7369 [details]
Upgrade Java 1.5, further refactoring

I have created a patch that 

 * makes code Java 1.5+ compatible
 * changes to the Java 1.5 AWT layout (no other libraries are necessary)
 * Switch over to full maven build
 * Creates different flavours of packages (library, source, runnable jar)
 * Refactored the directory structure ( /src -> /src/main )
 * Includes the commons-compress libraries from apache

All dependencies will be managed by maven, so all libraries can be removed from  the svn.

I have attached the patch here for review and inclusion

Comment 1 Sam Reed (reedy) 2010-05-13 22:22:07 UTC

Created attachment 7370 [details]
Unzipped version of already attached patch

Reuploading as a patch

Comment 2 p858snake 2010-05-14 04:41:44 UTC

keywords: +patch+need-review

Comment 3 orenbochman 2012-02-14 11:41:00 UTC

I was unaware of this patch and I've recently  committed some similar work myself.

Note: restructuring the project to the standard Maven setup would help future contributors to work on this project.

Comment 4 Johannes Weberhofer 2013-04-02 14:39:46 UTC

I've checked out the current version from the git repository and noticed that this old patch prepared by myself is not longer needed.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links