Last modified: 2014-11-04 22:51:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25498, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23498 - Search system does not respond quickly and sends partial text.
Search system does not respond quickly and sends partial text.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
unspecified
All All
: Highest critical with 5 votes (vote)
: ---
Assigned To: Adam Miller
:
: 23508 23511 23566 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-13 08:35 UTC by Nicholas Weiss
Modified: 2014-11-04 22:51 UTC (History)
17 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nicholas Weiss 2010-05-13 08:35:14 UTC
I'm not sure if this belongs in Lucene or here, but with the new search system, if typing a search entry and hitting enter quickly, only part of the search field will be sent, "Harrier" is desired, and I am redirected to "Har" if more time is taken to type and hit enter, the system works fine, but if typing quickly, this bug occurs.
Comment 1 Chad H. 2010-05-13 17:08:33 UTC
*** Bug 23508 has been marked as a duplicate of this bug. ***
Comment 2 Roan Kattouw 2010-05-13 22:11:48 UTC
*** Bug 23511 has been marked as a duplicate of this bug. ***
Comment 3 Adam Berman 2010-05-13 23:05:54 UTC
Also encountered on Windows on Firefox; others have reported on Village Pump (Technical) that they encountered it on Chrome, so it looks more or less universal. My best guess is that it has something to do with the search suggestions. If that's the case, recommend a temporary disable until it's fixed, as this is absolutely a dealbreaker from my point-of-view.
Comment 4 Robert Stojnic 2010-05-14 09:31:20 UTC
Bumping up this to a major bug. Hundreds of people are affected by this bug every second and it prevents them from getting to the page they want to get to. Please make it top priority to solve it.
Comment 5 Roan Kattouw 2010-05-14 10:41:07 UTC
bug 23517 is related
Comment 6 gamepro777 2010-05-14 17:38:49 UTC
Also reporting this bug.  Getting irritating that the box/search cannot keep up with fast typers.  Typically searches based on what you had typed in when it began to suggest searches.
Comment 7 Ian Woollard 2010-05-15 01:45:48 UTC
Something like 50% of the article hits go through this search box (the rest go through google). The importance of this bug cannot be overstated. We're looking at millions of people affected.
Comment 8 Robert Stojnic 2010-05-15 02:33:32 UTC
If the issues cannot be resolved today, it might be best just to temporarily disable SimpleSearch, as the commons vector-tested old search seemed to have worked fine.
Comment 9 Matthew P. Del Buono 2010-05-15 02:41:42 UTC
Confirming the issue here. It really seems to me like it's not actually a performance issue, but rather that it's caused by the delay from querying the server for suggestions. A possible guess is that it's capturing the first few keys, sending a request, then more keys are typed and the user pushes "enter" before a response is received, and the contents that triggered the initial request are what is taken.

But I haven't looked into the code for this, that is just what it feels like based on experimental usage.
Comment 10 Roan Kattouw 2010-05-15 10:27:27 UTC
(In reply to comment #8)
> If the issues cannot be resolved today, it might be best just to temporarily
> disable SimpleSearch, as the commons vector-tested old search seemed to have
> worked fine.

Since this is not realistically going to be fixed over the weekend, I've gone ahead and done exactly this. The JS part of SimpleSearch has been disabled until we sort out this issue. The search bar still looks the same, and mwsuggest has taken over the AJAX search suggestions.
Comment 11 Tore T. S. 2010-05-15 23:16:25 UTC
(In reply to comment #10)
> Since this is not realistically going to be fixed over the weekend, I've gone
> ahead and done exactly this. The JS part of SimpleSearch has been disabled
> until we sort out this issue. The search bar still looks the same, and
> mwsuggest has taken over the AJAX search suggestions.

FYI, I just checked and the bug is still present.
Comment 12 Tore T. S. 2010-05-15 23:31:26 UTC
Expanding on my previous comment: it seems like the bug now appears less frequently, but it is still possible to get it if you type very quickly and press enter immediately after typing. Either letters will disappear from the end of the search string, or you will be taken to the search page as if you didn't type anything at all. It does seem like you need to type faster than before in order to get it though.
Comment 13 Ian Woollard 2010-05-16 15:42:23 UTC
Is this commons or wikipedia Tore?

The bug seems to be not present currently on the English Wikipedia for me using the latest release of Firefox.
Comment 14 Roan Kattouw 2010-05-17 09:18:46 UTC
I just realized that the way I disabled SimpleSearch meant it wouldn't be disabled for anonymous users immediately due to caching. I have now fixed this.
Comment 15 gamepro777 2010-05-17 14:00:14 UTC
Tested this morning, confirming that it is still an issue.  Using IE8, English Wikipedia, last few characters of search still being trimmed as the suggested search area shows up under.
Comment 16 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-05-17 14:07:43 UTC
Confirmed, this is still present for me on enwiki.  Both logged in and logged out, including with cleared cache.
Comment 17 Ian Woollard 2010-05-17 14:19:45 UTC
Yes, bug is back now on English wikipedia using firefox.
Comment 18 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-05-17 15:11:21 UTC
*** Bug 23566 has been marked as a duplicate of this bug. ***
Comment 19 Adam Miller 2010-05-17 15:26:41 UTC
Fixed in r66565. We'll test it a little more and try to get the fix deployed as soon as possible.
Comment 20 Roan Kattouw 2010-05-17 16:41:05 UTC
(In reply to comment #17)
> Yes, bug is back now on English wikipedia using firefox.

I thought I had disabled SimpleSearch properly this time around, but it looks like I still hadn't. I got Domas to purge the JS in Varnish; clearing your browser cache or doing a hard refresh (Ctrl+F5 in most browsers) should disable SimpleSearch for real.
Comment 21 Ian Woollard 2010-05-24 15:37:53 UTC
The bug is back!!!
Comment 22 Ian Woollard 2010-05-27 18:02:27 UTC
Seems OK again. maybe a caching problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links