Last modified: 2013-04-22 16:15:23 UTC
Created attachment 7360 [details] remove extra space from a.external.text rule in commonPrint.css When printing an external link, the stylesheet appends the link's URL with surrounding spaces. The final space is inappropriate when the link is followed by punctuation, and unnecessary otherwise. For instance, "[http://mediawiki.org MediaWiki], a popular free software package" prints as "MediaWiki (http://mediawiki.org) , a popular free software package". Patch included to get rid of the extra space.
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Thanks for the patch, Lee! Sorry for the long wait. I am adding the "need-review" keyword so developers know that this patch hasn't been reviewed yet.
Lee, I'm sorry that, because of the delay, your patch no longer applies to MediaWiki's current codebase. Is the bug still happening? If so, would you be interested in updating your patch? If you do, and attach the "need-review" and "patch" keywords, we'll make sure to review it a lot faster. Again, I'm sorry.
Comment on attachment 7360 [details] remove extra space from a.external.text rule in commonPrint.css Patch no longer applies to MediaWiki trunk in Subversion. Tested by Rusty in http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html
Seems to still apply: $:andre\> grep -r "attr(href)" . ./common/commonPrint.css: content: " (" attr(href) ") ";
https://gerrit.wikimedia.org/r/#/c/55518/ seems to address this bug.
