Last modified: 2011-03-13 18:06:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4347, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 2347 - Add defensive code for failure of Turck cache puts.


Summary:	Add defensive code for failure of Turck cache puts.

Status:	RESOLVED WONTFIX

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	1.4.x
Hardware:	All All

Importance:	Lowest normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-06-07 23:45 UTC by Carlton Brown
Modified:	2011-03-13 18:06 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Carlton Brown 2005-06-07 23:45:51 UTC

The wrapper class for MW, BagOTurckStuff, does not check the return 
value of mmcache_put.  Thus, functions that depend on this caching 
are unaware that caching has failed, and unexplained failures 
result.

Suggestions:
1) Check the return value of mmcache_put and possibly mmcache_get, 
to handle or log exceptional cases

2) Add warning comment in LocalSettings.php that Turck data caching 
is not certified for all environments and may cause message 
substitution failures

Comment 1 Carlton Brown 2005-06-07 23:47:13 UTC

First 2 phrases should have read: "The MW wrapper class for Turck Mmemcache, 
BagOTurckStuff"

Comment 2 Brion Vibber 2005-12-12 02:41:34 UTC

The caches are assumed to be lossy, so a silent failure is not a problem.
Resolving WONTFIX.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links