Last modified: 2012-05-23 19:53:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2346 - Special characters break section links in page history
Special characters break section links in page history
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.4.x
All All
: Low normal with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
: patch, patch-need-review, testme
: 11006 (view as bug list)
Depends on:
Blocks: 5019
  Show dependency treegraph
 
Reported: 2005-06-07 22:23 UTC by Dan Smith
Modified: 2012-05-23 19:53 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed fix (924 bytes, patch)
2006-08-26 21:36 UTC, Wil Mahan
Details
Updated patch against r104197 (915 bytes, patch)
2011-11-24 21:36 UTC, Dan Collins
Details

Description Dan Smith 2005-06-07 22:23:12 UTC
When a section title includes certain special or non-alphabetical characters
(i.e. any that do not appear as themselves in a URL, such as parentheses, etc),
or any piped links, the linked arrow in the page's history breaks.

For example, in the history of [[Wikipedia:Administrators'
Noticeboard/Incidents]], when someone edits the section entitled
[[User:Violetriga|violet/riga]], the arrow links to
#User:Violetriga.7Cviolet.2Friga, when it should link to #violet.2Friga.
Comment 1 Zigger 2005-06-09 15:56:38 UTC
Also, the parsing of the wikilink at the start of the summary in the history
line is confusing, although not broken like the arrow link.  The section title
is "[[User:Violetriga|violet/riga]]".  The summary prefix when editing is "/*
[[User:Violetriga|violet/riga]] */ ".  The history line shows a section title of
"violet/riga".  The link is to the page "User:Violetriga".  And there is no gap
between the arrow link and the "violet/riga" link.

See bug 1305, which discusses changes to the arrow/summary link.
Comment 2 lɛʁi לערי ריינהארט 2005-10-13 16:10:12 UTC
The original URL is outdated. You can find the examples with
http://en.wikipedia.org/w/index.php?title=Wikipedia:Administrators%27_noticeboard/Incidents&offset=20050607004643&limit=500&action=history

Please note that what looks in history as one link (→violet/riga) are two links
a) →
wroung
http://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard/Incidents#User:Violetriga.7Cviolet.2Friga
should be
http://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard/Incidents#violet.2Friga
as for
http://en.wikipedia.org/w/index.php?title=Wikipedia:Administrators%27_noticeboard/Incidents&oldid=14816929#violet.2Friga

b) violet/riga
- http://en.wikipedia.org/wiki/User:Violetriga


What should be done:
i) insert always a space after "→"

ii) fix the problem related to
bug 2831: return after edit sections using headings with wikilinks returns to
other anchors then the ones used in TOC

Regards Reinhardt [[user:gangleri]]
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-07 22:43:10 UTC
Patch is available at bug 5019.
Comment 4 Wil Mahan 2006-08-26 21:36:00 UTC
Created attachment 2271 [details]
Proposed fix

Here's a shot at fixing this bug. This patch is less
ambitious than Simetrical's at bug 5019, but it
seems to fix the problem without breaking anything.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-08-20 18:11:39 UTC
*** Bug 11006 has been marked as a duplicate of this bug. ***
Comment 6 p858snake 2011-04-30 00:09:52 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 7 Sumana Harihareswara 2011-11-21 10:44:16 UTC
Comment on attachment 2271 [details]
Proposed fix

Patch no longer applies to trunk, so marking obsolete (checked by Rusty per
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html ).
Comment 8 Sumana Harihareswara 2011-11-21 10:44:38 UTC
Will, if you'd like to revise your patch to work with the current codebase,
that would be welcome; if you'd like suggestions or discussion, please chat
with other MediaWiki developers in #mediawiki on Freenode IRC. Thanks!
Comment 9 Dan Collins 2011-11-24 21:36:56 UTC
Created attachment 9551 [details]
Updated patch against r104197

Linker.php has changed a bit since then but here's my best guess at what that's supposed to do. That code moved from formatComment to formatAutocomments and then to formatAutocommentsCallback. This patch introduces the use of the global $wgLegalTitleChars.
Comment 10 Dan Collins 2012-05-23 19:53:30 UTC
Seems to be fixed on en.wiki

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links