Last modified: 2012-09-27 01:10:50 UTC
Created attachment 7359 [details] Screenshot of the error The top 1px gets cut off on both Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3 and Google Chrome 5.0.307.11 beta. On my wiki, I set: #content a[href^="irc://"], #content a.extiw[href^="irc://"], .link-irc { padding: 1px 18px 0 0; }
Yes, the icons need to be lower sizes to be able to be shown inline with text in most cases.
Solved in r66151.
This makes the icons tiny, which means all the detail inside the icons is gone. Furthermore, monobook somehow manages to get the icons to not be cut off when they're taller than line-height, can't vector do the same? It is 1px off, no need to butcher the icons by 6px. Is there some reason adjusting padding by 1px isn't good enough?
The larger icons were stock 16px icons pulled from the tango library which are actually only 14px since they had a 1px clear border around them. If you look at the sizes of the actual graphics in the Monobook icons, you will see that they are all between 10 and 12 pixels in height, so we're really talking about somewhere between 0 and 2 pixels difference between Vector and Monobook. Vector's icons are more consistently sized than those of Monobook, which is essentially the justification for the 2px differences where they occur. Additionally, the sizes we're using here flow more consistently with the text, given they are more consistently similar to the height of the rendered text in most situations. So, sure - span padding is clever, but it's not really going to solve the real problem, that the icons were actually too large to begin with.
