Last modified: 2011-02-27 22:02:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25415, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23415 - mark articles as needing review after an included file is moved to Commons
mark articles as needing review after an included file is moved to Commons
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Aaron Schulz
:
: 26527 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-05 19:33 UTC by merl
Modified: 2011-02-27 22:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description merl 2010-05-05 19:33:15 UTC
If an article is reviewed and after this an embedded image in transfered from local wiki to commons and then the local image is deleted, the commons image is not shown but an blue link to the file page. You can only watch the image if you add ?stable=0

But the article is not marked as unreview nor a review link is shown at the article. To solve the problem you have to unreview the article first and then review the actual version.

For a quick solution it would help if all articles get unreviewed in their last version if an image is deleted.
This already happens if there is a never reviewed image and a new image version is uploaded. Then on all articles an review box is shown with "following images/templates have changed ....".
Comment 1 Aaron Schulz 2010-06-14 00:14:11 UTC
File deletions handled in r67964.
Comment 2 Aaron Schulz 2010-06-14 22:21:24 UTC
Reopening - work still needed
Comment 3 Aaron Schulz 2010-06-15 04:00:17 UTC
Done in r68057.
Comment 4 merl 2011-02-27 13:43:15 UTC
Bug still exists. I have written a query on toolserver which shows about 10000 results on dewiki:
 SELECT page_title, il_to 
  FROM dewiki_p.flaggedpages
   INNER JOIN dewiki_p.flaggedrevs ON fp_page_id = fr_page_id AND fp_stable=fr_rev_id
   INNER JOIN dewiki_p.imagelinks ON fp_page_id = il_from
   INNER JOIN dewiki_p.filearchive ON il_to = fa_name
   INNER JOIN dewiki_p.page ON fp_page_id = page_id
   LEFT JOIN dewiki_p.image i ON il_to = i.img_name
   INNER JOIN commonswiki_p.image ci ON il_to = ci.img_name
  WHERE page_namespace=0 AND i.img_name IS NULL AND fa_deleted_timestamp > fr_timestamp AND fp_reviewed > 0;

Latest result is https://secure.wikimedia.org/wikipedia/de/w/index.php?title=Kaspar_Ritter_(Egg)#Heimatstilvilla_Nr._499 reviewed on 20110226180739 and image deleted later on that day (20110226180947).

I check many of these results and all still have the problem not showing the images. I'll start unreviewing/reviewing those page on dewiki soon to reduce the imact of this bug on dewiki.
Comment 5 Aaron Schulz 2011-02-27 19:16:35 UTC
bug 26527 looks like a duplicate
Comment 6 Aaron Schulz 2011-02-27 19:27:41 UTC
*** Bug 26527 has been marked as a duplicate of this bug. ***
Comment 7 Aaron Schulz 2011-02-27 19:53:27 UTC
(In reply to comment #6)
> *** Bug 26527 has been marked as a duplicate of this bug. ***

As noted there, the bug 15748 code is the cause of this.
Comment 8 Aaron Schulz 2011-02-27 22:02:08 UTC
Fixed in r82917.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links