Last modified: 2013-04-17 12:37:30 UTC
When a Header is created with a code like <h1>Header 1</h1> it shows correctly, but the same doesn't happens when we use <h1>Header 2 </h1> (with a line break before the closing tag) See for example this link: http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&oldid=359875876#toctitle Helder
Still happening. It is actually not displayed in the TOC at all. This is probably caused by the regex used to match headings in Parser.php: /<H(?P<level>[1-6])(?P<attrib>.*?'.'>)(?P<header>.*?)<\/H[1-6] *>/i The dot in '.*?' will match all characters except a newline. It should be changed to [\s\S], or we could add a 's' at the end.
I0f2d81dd.
Merged by Brion.
This patch adds an entry to RELEASE-NOTES-1.21 yet is not on the REL1_21 branch. Should it be backported?
(In reply to comment #4) > This patch adds an entry to RELEASE-NOTES-1.21 yet is not on the REL1_21 > branch. Patch for this and other errors in the release notes appreciated. :)
(In reply to comment #5) > (In reply to comment #4) > > This patch adds an entry to RELEASE-NOTES-1.21 yet is not on the REL1_21 > > branch. > > Patch for this and other errors in the release notes appreciated. :) I'll upload a patch for this soon (and will post the link here). I just wanted someone to confirm that it is an error first :)
Related URL: https://gerrit.wikimedia.org/r/59620 (Gerrit Change I6a51e3ee07fe7622b9c708c78563795d7a1118fc)
