Last modified: 2010-05-05 16:10:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25363, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23363 - Multiple indicators of status of transcluded page
Multiple indicators of status of transcluded page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: ThomasV
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-05-01 08:29 UTC by Beau
Modified: 2010-05-05 16:10 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
The patch removes incorrect OutputPageBeforeHTML hook (1.28 KB, patch)
2010-05-02 19:49 UTC, Beau 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Beau 2010-05-01 08:29:21 UTC 
When I view a page in main namespace which transcludes from Page: namespace I can see status of transcluded pages under the title. When I edit that page, there are two quality indicators, when I preview my edit, there are three. There is no need for such duplication.
Comment 1 Beau 2010-05-02 19:49:55 UTC 
Created attachment 7346 [details]
The patch removes incorrect OutputPageBeforeHTML hook

I have created a patch, which removes OutputPageBeforeHTML hook (it gets called every time addParserOutput method is used).

The status of transcluded pages should be added in the BeforePageDisplay hook.
Comment 2 ThomasV 2010-05-05 16:02:18 UTC 
Thanks for the patch. However, this is going to make the hook function return without calling pr_prepareArticle; it is better to setup the subtitle in pr_prepareArticle.
Comment 3 ThomasV 2010-05-05 16:10:01 UTC 
fixed in r65954
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links