Last modified: 2011-01-29 21:21:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 23361 - Upgrade imagemagick - Thumbnailing of files with question marks ("?") in their names broken
Upgrade imagemagick - Thumbnailing of files with question marks ("?") in thei...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Fil...
: shell
: 23963 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-01 01:00 UTC by Ilmari Karonen
Modified: 2011-01-29 21:21 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ilmari Karonen 2010-05-01 01:00:03 UTC
It seems thumbnailing of files with question marks in their names in broken on Commons as of recently.  See discussion here:

http://commons.wikimedia.org/w/index.php?title=Commons:Administrators%27_noticeboard&oldid=38497461#File:Domine.2C_quo_vadis.3F.jpg

Some example files:

http://commons.wikimedia.org/wiki/File:4%3F%3F%3F%3F_Kopie.jpg
http://commons.wikimedia.org/wiki/File:D%3FK.png
http://commons.wikimedia.org/wiki/File:Somewhere_in_norway%3F.jpg

The error message I get when trying to view one of the broken thumbnails is:

Error creating thumbnail: convert: unable to open image `/mnt/upload6/wikipedia/commons/9/94/D\?K.png': No such file or directory.
convert: unable to open file `/mnt/upload6/wikipedia/commons/9/94/D\?K.png'.
convert: missing an image filename `/mnt/thumbs/wikipedia/commons/thumb/9/94/D?K.png/600px-D?K.png'.

I'd suspect the recent deployment of r65467, but have not been able to reproduce the bug on my local wiki so far.
Comment 1 Ilmari Karonen 2010-05-01 01:16:24 UTC
It seems existing thumbs continue to be served correctly as long as no-one purges them.  According to the 7 April 2010 dump, there are 748 potentially affected files on Commons.  List here:

http://commons.wikimedia.org/wiki/User:Ilmari_Karonen/%3F
Comment 2 Tim Starling 2010-05-01 21:57:25 UTC
Yes it's caused by r65467. It can be fixed by deploying an updated ImageMagick, including r1719 and r1736:

http://trac.imagemagick.org/changeset/1719/ImageMagick/trunk/magick/token.c
http://trac.imagemagick.org/changeset/1736/ImageMagick/trunk/magick/token.c
Comment 3 Ilmari Karonen 2010-05-02 01:59:31 UTC
Oh, OK.  I thought we were maintaining compatibility with old ImageMagick versions, though (see e.g. bug 11822).  Is this something that just _can't_ be fixed on our end without introducing a bleeding-edge ImageMagick dependency?  If so, it should at least be very clearly noted in the release notes.

(I suspect I'm missing some detail here, though, since I don't seem to be able to reproduce this bug on my own wiki, and I'm pretty sure my hosting provider hasn't updated ImageMagick that recently.)
Comment 4 Tim Starling 2010-06-08 06:08:59 UTC
There is no way to uniquely specify source images that have question marks in their names, before the ImageMagick bug fix. Documented in RELEASE-NOTES as requested in r67591.
Comment 5 Bryan Tong Minh 2010-06-18 20:26:28 UTC
Is bug 23963 related, or is that a different problem?
Comment 6 Platonides 2010-06-18 20:29:12 UTC
*** Bug 23963 has been marked as a duplicate of this bug. ***
Comment 7 Platonides 2010-06-18 20:31:54 UTC
It's the same issue. Changing to a shell request to upgrade ImageMagick to 6.6.1-5 or later.
Comment 8 Tim Starling 2010-08-11 09:14:05 UTC
Are there any test cases left that Commons admins haven't destroyed?
Comment 9 Ilmari Karonen 2010-08-11 09:21:34 UTC
(In reply to comment #8)
Try http://commons.wikimedia.org/wiki/File:TEST%3F.png
Comment 10 Tim Starling 2010-08-11 12:27:41 UTC
Fixed now, I deployed 6.6.2-6.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links