Last modified: 2013-03-15 11:07:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25339, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23339 - bogus page/user invalidations
bogus page/user invalidations
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on: 20468
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-28 01:47 UTC by Domas Mituzas
Modified: 2013-03-15 11:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Domas Mituzas 2010-04-28 01:47:32 UTC
CentralAuth is causing needless page/user invalidations.

Existing bad code paths:

- Title cache invalidation should be done only when email settings actually changed

LoginForm::execute
LoginForm::processLogin
LoginForm::authenticateUserData
CentralAuthPlugin::updateUser
User::saveSettings
Title::invalidateCache

- we should invalidate user cache only when there are changes that would need different rendering logic, not for every centralauthhooks session reload

User::getOption
User::loadOptions
User::load
User::loadFromSession
wfRunHooks
call_user_func_array
CentralAuthHooks::onUserLoadFromSession
CentralAuthHooks::initSession
User::invalidateCache
Comment 2 Mark A. Hershberger 2011-06-15 19:41:12 UTC
lowering priority, unassigning reedy.
Comment 3 Mark A. Hershberger 2011-07-06 16:32:40 UTC
Think this is mostly done... shouldn't block 1.18
Comment 4 Andre Klapper 2013-03-15 11:07:23 UTC
(In reply to comment #1)
> http://svn.wikimedia.org/doc/
> classUser_a124949b4a526ad6885f7f98816d3862d_icgraph.png

404 now. :-/

Wondering what's the status of this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links