Last modified: 2010-12-03 20:31:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25332, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23332 - Move RevisionDelete backend classes to their own files
Move RevisionDelete backend classes to their own files
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-26 19:43 UTC by Church of emacs
Modified: 2010-12-03 20:31 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Church of emacs 2010-04-26 19:43:26 UTC 
Currently everything is in SpecialRevisiondelete.php.

Either put it somewhere in includes or create a directory revisiondelete in includes and put each class in its own file (there are about 13 classes, some of them can probably be in the same file, but we should at least separate abstract classes from non-abstract ones).
Comment 1 Sam Reed (reedy) 2010-05-24 23:25:51 UTC 
r66856 splits the stuff that isn't the special page into it's own file

Need to decide if that suffices, or to split it further
Comment 2 Sam Reed (reedy) 2010-05-24 23:33:11 UTC 
Scrap that link, I made a complete hash of that commmit

r66858
Comment 3 Sam Reed (reedy) 2010-12-03 20:15:57 UTC 
r77675, r77677 adds a directory and moves Revision delete
Comment 4 Sam Reed (reedy) 2010-12-03 20:31:41 UTC 
r77678, r77679 finished this off (at least, abstracts out of the file)

Not sure how much more splitting this needs.. But this is probably ok (it's better than it all being in SpecialRevisiondelete.php)

Explicitally added abstract classes to autoloader too
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links