Last modified: 2010-04-26 14:53:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25302, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23302 - Hard coded OldLocalFile Class in LocalFile::getHistory stops custom File Repos
Hard coded OldLocalFile Class in LocalFile::getHistory stops custom File Repos
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Chad H.
http://www.mediawiki.org/wiki/Extensi...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-23 18:04 UTC by Jack D. Pond
Modified: 2010-04-26 14:53 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Modification to LocalFile::getHistory to allow custom repos (692 bytes, patch)
2010-04-23 18:04 UTC, Jack D. Pond
Details

Description Jack D. Pond 2010-04-23 18:04:17 UTC
Created attachment 7326 [details]
Modification to LocalFile::getHistory to allow custom repos

FileRepo has a parameter that allows custom factory for creating file object from a row($oldFileFromRowFactory), but prevents it from working because LocalFile::getHistory hardcodes as follows:

$r[] = OldLocalFile::newFromRow( $row, $this->repo );

This fix would allow the existing configuration option to work.

There is an alternative work-around which is to overwrite getHistory in the custom Repo, but since the configuration option already exists, it might make sense to actually make it work.
Comment 1 Jack D. Pond 2010-04-26 14:53:48 UTC
fixed in r65543

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links