Last modified: 2011-11-09 15:32:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25278, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 23278 - Two hooks for edit page: after toolbar and after edit box


Summary:	Two hooks for edit page: after toolbar and after edit box

Status:	RESOLVED WORKSFORME

Product:	MediaWiki
Classification:	Unclassified
Component:	Interface (Other open bugs)
Version:	1.15.x
Hardware:	All All

Importance:	Low enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-21 19:08 UTC by Dan Barrett
Modified:	2011-11-09 15:32 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch against 1.15.3 (774 bytes, patch) 2010-04-21 19:09 UTC, Dan Barrett	Details
hooks.txt patch against 1.15.3 (875 bytes, patch) 2010-04-21 21:03 UTC, Dan Barrett	Details
Add an attachment (proposed patch, testcase, etc.)

Description Dan Barrett 2010-04-21 19:08:58 UTC

Enclosed is a patch that adds two hooks to includes/EditPage.php:

- After the edit box
- After the toolbar

Patch is against 1.15.3.

Comment 1 Dan Barrett 2010-04-21 19:09:21 UTC

Created attachment 7318 [details]
Patch against 1.15.3

Comment 2 Sam Reed (reedy) 2010-04-21 19:13:38 UTC

A comment for this and bug 23276

It'd be useful if you could also update hooks.txt with the relevant information (as otherwise the developers still have to do the documentation update, in the file and onwiki).

Thanks for the patches though! I'll look at applying them later

Comment 3 Dan Barrett 2010-04-21 21:02:50 UTC

Thanks Reedy. I did not update hooks.txt in case you decided to change the names of my hooks.  I will upload a patch now.

Comment 4 Dan Barrett 2010-04-21 21:03:17 UTC

Created attachment 7319 [details]
hooks.txt patch against 1.15.3

Comment 5 Sam Reed (reedy) 2010-04-24 11:02:10 UTC

Ok, thanks for that. Doing it against trunk yields some different results

For your

wfRunHooks( 'EditPageAfterToolbar', array(&$this, &$toolbar) );

At line 2248 of trunk EditPage.php

wfRunHooks( 'EditPageBeforeEditToolbar', array( &$toolbar ) );

Added in 1.16 - http://www.mediawiki.org/wiki/Manual:Hooks/EditPageBeforeEditToolbar


For the other hook, I'm not quite sure where you want it...

Line 1746 has a hook, but not passing the same paramters..

Comment 6 Antoine "hashar" Musso (WMF) 2010-10-11 06:43:43 UTC

adding keywords. Moving from "Special pages" to "general/unknown"

Comment 7 Sumana Harihareswara 2011-11-09 02:43:22 UTC

Dan, thank you for your work. It looks like Sam Reed (Reedy) had a few questions for you about your patch, so I'm marking this bug with the "reviewed" keyword.  If you have time to check current functionality, see if a patch is still necessary, and update your patch against current trunk if so, we'd appreciate it.  Thanks again.

Comment 8 Dan Barrett 2011-11-09 15:30:19 UTC

All is well. You can close this ticket.

Comment 9 Sumana Harihareswara 2011-11-09 15:32:26 UTC

Thanks, Dan!  Sounds like things work now :-)

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links