Last modified: 2013-01-06 11:38:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25257, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23257 - Latest commit to LdapAuthentication (r65189) has typo on line 1324
Latest commit to LdapAuthentication (r65189) has typo on line 1324
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LdapAuthentication (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-20 00:53 UTC by drstitch
Modified: 2013-01-06 11:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description drstitch 2010-04-20 00:53:36 UTC
The latest update of LdapAuthentication that came out this weekend
broke our LDAP authenticated wikis.

While I'm not a PHP expert, it would seem there's an errant '.' at the
end of line 1324 in LdapAuthentication.php (white space trimmed, line 1325
included) :

if ( ( isset( $wgLDAPGroupsPrevail[$_SESSION['wsDomain']] ).
         && $wgLDAPGroupsPrevail[$_SESSION['wsDomain']] ) && count( $this->userLDAPGroups ) != 0 ) {

If I remove the errant '.', my sites come back just fine.  If that's not the 
proper fix, let me know so I can start figuring out what else is borked.

Thanks!
-Tim Miller
Comment 1 Roan Kattouw 2010-04-20 09:08:13 UTC
Fixed by Raymond in r65285.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links