Last modified: 2014-09-24 00:06:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25238, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23238 - Add tabindex to Special:Upload
Add tabindex to Special:Upload
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.17.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: 43562
  Show dependency treegraph
 
Reported: 2010-04-18 19:10 UTC by Derk-Jan Hartman
Modified: 2014-09-24 00:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Tabindex for Upload (4.11 KB, patch)
2010-04-20 20:32 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2010-04-18 19:10:30 UTC
To quote the user on Commons: "I usually use the "tab" buton to navigate the upload form. One issue I have is that now, when I want to get from the "permission" field to the categories, I have to "tab" my way through the entire special chars menu (or of course, use the dreaded "cursor"). It would be neat if the "tab" could skip the special chars on its way down towards the "upload" button."

I agree with the user. This can be easily done by setting "tabindex" property of the upload field.
Comment 1 Bryan Tong Minh 2010-04-18 19:17:59 UTC
Note that the upload button has its own short key (ctrl-alt-s from the top of my memory).
Comment 2 Derk-Jan Hartman 2010-04-20 20:32:01 UTC
Created attachment 7315 [details]
Tabindex for Upload

Patch that adds tabindex to the Upload page.

Adds partial support for tabindex to HTMLForm.php. Not supported for all fields, and not supported yet for the submit button.

Should I add a setSubmitTabIndex() ? How then to handle the other buttons ? keep counting ?

Could also not get the tabindex to work for the license selector for some reason. almost seems if setAttribute for XmlSelect just doesn't do a thing.
Comment 3 Sumana Harihareswara 2011-11-10 06:50:03 UTC
+need-review inferring from "Should I add a setSubmitTabIndex() ? How then to handle the other buttons ? keep counting ?" that Derk-Jan would like some design review
Comment 4 Sumana Harihareswara 2012-10-12 01:18:50 UTC
Jan, could I ask you to take a look at this and see whether it would be worth updating & putting into Gerrit?  Thanks.
Comment 5 Andre Klapper 2012-11-26 13:45:53 UTC
jgerber: Could you review comment 2 here, please?
Comment 6 Jan Gerber 2012-11-26 14:01:37 UTC
This is more a question about accessibility, is tabindex used for other forms?

Also, now that UploadWizard is the default uploag page, is Special:Upload still used? It comes only up for uploading a new version as far as I know.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links