Last modified: 2011-02-11 07:32:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25211, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23211 - #formlink, #forminput 'query string=' parameter doesn't allow pipes in values
#formlink, #forminput 'query string=' parameter doesn't allow pipes in values
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-16 21:06 UTC by Neill Mitchell
Modified: 2011-02-11 07:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neill Mitchell 2010-04-16 21:06:22 UTC
Hi.

I have a formlink definition:

{{#formlink:Subsection Form|Add a Subsection|link type=button|Subsection 
Template[Parent]={{PAGENAME}}&Subsection Template[Section 
ID]={{{Section}}}&Subsection Template[Level]={{#op|{{{Level}}}|+|1}}}}

Level is a numeric property. {{#op|{{{Level}}}|+|1}} is a Winter 
function that increments Level by one.

With SF 1.8.5 this works fine. The incremented Level appears correctly 
in the Subsection template.

However, when I upgrade to SF 1.9 "<b>" appears in the Level field 
instead of the incremented number. Clearly the {{#op|{{{Level}}}|+|1}} 
is no longer being parsed correctly.

I updated the call format to:
{{#formlink:form=Subsection Form|link text=Add a Subsection|link 
type=button|query string=Subsection 
Template[Parent]={{PAGENAME}}&Subsection Template[Section 
ID]={{{Section}}}&Subsection Template[Level]={{#op|{{{Level}}}|+|1}}}}

But it made no difference.
Comment 1 Neill Mitchell 2010-04-19 16:55:27 UTC
Upping the importance as this query string= change busts a lot of existing functionality. You can't have pass anything but basic strings into forms now, which is really limiting.

Cheers
Neill.
Comment 2 Neill Mitchell 2010-04-20 09:36:05 UTC
Hi. 

I've found another way of passing the variable in that works.

Yaron, close this if you want to unless you want to use this as an example of the query string= parsing not working fully. 

Cheers
Neill.
Comment 3 Yaron Koren 2010-04-21 06:49:12 UTC
Changing back to "normal" severity.
Comment 4 Yaron Koren 2011-02-11 07:32:52 UTC
This was apparently fixed at some point between then and now. :) Setting to "fixed".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links