Last modified: 2014-01-11 17:44:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25185, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23185 - Long property values of type Text wrapped inside a html tag sometimes breaking the site layout when factbox is visible
Long property values of type Text wrapped inside a html tag sometimes breakin...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Markus Krötzsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-13 21:47 UTC by Daniel A. R. Werner
Modified: 2014-01-11 17:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2010-04-13 21:47:43 UTC
When the factbox is visible (usually on page preview) and there is a property value of type Text assigned where the text is very long and wrapped inside a <div> or <span>, the site layout will break completely.

The text between the starting and ending text must me long as well to trigger this. Perhaps there are other circumstances needed to trigger this It doesn't happen every time I would expect it...

Example:
http://sandbox.semantic-mediawiki.org/wiki/Nested_div_in_long_text_property_value
Comment 1 badon 2011-12-03 21:54:08 UTC
I ran into this problem with properties of type URL. Long URLs are routine. I solved the issue with this bit of CSS in my MediaWiki:Common.css:

/* Ensures long URLs in the SMW factbox don't ruin page layout */
.smwprops { word-wrap:break-word; }

the smwprops class should probably have that CSS added to it in SMW core. That will probably solve the problem except maybe in unusual cases where the properties themselves contain markup that interferes with that CSS. I'm not sure how to handle that, but for now, my "patch" above should solve the problem in most cases.
Comment 2 MWJames 2014-01-11 17:44:07 UTC
Resolved with SMW 1.9, see [1].

[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/includes/Factbox.php#L314

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links