Last modified: 2010-04-12 10:45:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25167, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23167 - Regression: Uploaded files are not longer added to watchlist even if "Add pages I create to my watchlist" is enabled in preferences
Regression: Uploaded files are not longer added to watchlist even if "Add pag...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-12 09:38 UTC by Raimond Spekking
Modified: 2010-04-12 10:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2010-04-12 09:38:32 UTC
Regression: Uploaded files are not longer added to watchlist even if "Add pages I create to my watchlist" is enabled in preferences.
Comment 1 Sam Reed (reedy) 2010-04-12 10:05:26 UTC
r1=64196&r2=64197&pathrev=64197">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiUpload.php?r1=64196&r2=64197&pathrev=64197

It looks like to me, that it never did (or at least, from the API's POV, it didn't tell it to)

		$watch = $this->getWatchlistValue( $params['watchlist'], $file->getTitle() ) || $wgUser->getOption( 'watchcreations' );

Would fix on the API..
Comment 2 Raimond Spekking 2010-04-12 10:14:20 UTC
(In reply to comment #1)
> r1=64196&r2=64197&pathrev=64197">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiUpload.php?r1=64196&r2=64197&pathrev=64197
> 
> It looks like to me, that it never did (or at least, from the API's POV, it
> didn't tell it to)

Tested as normal user in a 1.15: Yes, it works there. At time of calling Special:Upload the box is ticked already and after successfully upload the file is on my watchlist.
Comment 3 Sam Reed (reedy) 2010-04-12 10:23:30 UTC
API done in r64955

Re the UI

<Bryan> some magic needs to be put in UploadForm::getOptionsSection
Comment 4 Sam Reed (reedy) 2010-04-12 10:45:22 UTC
Bryan did the GUI in r64957

API fixed betterer in r64958

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links