Last modified: 2012-05-25 02:43:24 UTC
When create a new section an non existing page with section=new the "show changes" button gives no diff. Works fine on existing page and without section=new. Steps to reproduce: * Go to non existing talk page * click '+' (new section) * add a subject and text * click "show changes"
I suppose that one could be fixed quite easily, but the question is if "show changes" really makes sense. The diff will be just the new text, which is also in the text field. We really should think about just omitting the "show changes" button/tab when section=new. Although we might keep it for UI consistency.
The inconsistency is that the show changes button give a diff, when not create a new section on an non-existing page. The button is helpful to detect/prevent edit conflicts, because the function diffs always against the new version of a page and so changes is shown in the diff.
Created attachment 9007 [details] remove "bogus page" check The patch removed a "bogus page" check in WikiPage::replaceSection, because this fails on non-existing pages. Feel free to modify the patch. Thanks.
Comment on attachment 9007 [details] remove "bogus page" check Patch is obsolete because with r107319 some things changed, which makes that patch useless.
