Last modified: 2012-11-03 09:27:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25122, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23122 - Deprecate $wgUseSharedUploads and friends
Deprecate $wgUseSharedUploads and friends
Status: NEW
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 40486
  Show dependency treegraph
 
Reported: 2010-04-09 22:03 UTC by Chad H.
Modified: 2012-11-03 09:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chad H. 2010-04-09 22:03:00 UTC
We have been using $wgForeignFileRepos since 1.11. Reminder bug to check WMF conf to make sure it's not using the old settings, then look at removing the back-compat stuff in Setup.php and removing these. I also don't think people were using the feature very much until Tim added $wgForeignFileRepos anyway.
Comment 1 Bryan Tong Minh 2010-05-02 19:52:52 UTC
I see no reason to remove this deprecated feature indefinitely unless it starts to break things.
Comment 2 Chad H. 2010-05-03 09:54:57 UTC
Having less configuration variables is always a good thing, imho. As long as it's clearly stated in the RELEASE-NOTES, I see little harm in removing them.
Comment 3 Krinkle 2011-03-20 16:11:11 UTC
As of:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/DefaultSettings.php?view=markup&pathrev=84169#l413

The following values are still existant and set to the following by default:

  $wgUseSharedUploads = false;

  $wgSharedUploadPath = "http://commons.wikimedia.org/shared/images";

  $wgFetchCommonsDescriptions = false;

  $wgSharedUploadDirectory = "/var/www/wiki3/images";

  $wgSharedUploadDBname = false;

  $wgSharedUploadDBprefix = '';

  $wgCacheSharedUploads = true;

The default value for wgSharedUploadPath is a 404 error and doesnt' work by default.
I suggest we

* Set these to sane (working) defaults

* Keep wgUseSharedUploads disabled by default (obviously)

* Make note of these variables being obsolete in the DefaultSettings.php and RELEASE-NOTES file and shorlty describe what the new settings should be (ie. ForeignFileRepo ) so a wiki admin can switch.

* Don't deprecate or remove them untill we have to for some reason (ie. it becoming impossible or cumbersome to support/convert these to new variables)

--
Krinkle
Comment 4 Bugmeister Bot 2011-08-19 19:12:33 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links