Last modified: 2010-12-06 10:11:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25119, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23119 - Deprecate WikiError
Deprecate WikiError
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-09 17:56 UTC by Happy-melon
Modified: 2010-12-06 10:11 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Happy-melon 2010-04-09 17:56:10 UTC
The WikiError class is used only in the Mail backend, very isolated areas in SpecialImport and SpecialUserrights, and a few odd bits scattered through filerepo; its documentation says it was implemented "because PHP4 doesn't have exceptions".  We now require PHP5, which *does* have exceptions, although I'm not entirely sure that they're entirely suitable for all the uses.  But between exceptions, Message string errors, and Status objects, this system is completely duplicated and extremely inconvenient to keep around; the mail system in particular creeps all over the place.
Comment 1 Brion Vibber 2010-04-16 11:44:50 UTC
I brought this evil into the world; I'll take it out... assigning to self.
Comment 2 Alexandre Emsenhuber [IAlex] 2010-04-16 15:58:23 UTC
Special:Userrights done in r65131, updated filerepo comments in r65128 since they use FileRepoStatus and not WikiError.
Comment 3 Alexandre Emsenhuber [IAlex] 2010-12-06 10:11:25 UTC
Marking this as FIXED since it was marked as deprecated in r77870 (last usage from core removed in 77800).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links