Last modified: 2010-04-09 20:07:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25117, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23117 - API rollback broken
API rollback broken
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-09 16:40 UTC by Alex B
Modified: 2010-04-09 20:07 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Alex B 2010-04-09 16:40:49 UTC 
As far as I can tell, the API rollback is broken on current the deployment version. The API simply returns 'badtoken' to all requests. 

No encoding has changed, and this affects JavaScript AJAX rollback scripts, huggle, the anti-vandalism bots which have stopped reverting, and so on.
Comment 1 Gurch 2010-04-09 18:00:46 UTC 
I've patched Huggle to use UI rollback (which still works) so that's OK for now.

Initially I figured it was mis-parsing the token, getting logged out, not sending the cookies properly or one of the other usual causes of 'badtoken' errors, but I also haven't been able to get API rollback working.
Comment 2 MZMcBride 2010-04-09 18:03:51 UTC 
An hour or so ago:

<logmsgbot> !log catrope synchronized php-1.5/includes/api/ApiRollback.php  'Live hack for bug 23117'
Comment 3 Roan Kattouw 2010-04-09 18:05:12 UTC 
I applied a live hack on the servers, does that fix it?
Comment 4 Philip Trueman 2010-04-09 18:20:25 UTC 
It works for me - and apparently also for ClueBot.  Many thanks.
Comment 5 Alex B 2010-04-09 18:52:29 UTC 
Yep, that fixed it. Thanks.
Comment 6 Sam Reed (reedy) 2010-04-09 20:07:45 UTC 
And properly fixed on svn head in r64826
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links