Last modified: 2010-04-16 07:03:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25080, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23080 - Very long usernames can't have personal javascript/css files
Very long usernames can't have personal javascript/css files
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-07 10:16 UTC by Conrad Irwin
Modified: 2010-04-16 07:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Conrad Irwin 2010-04-07 10:16:13 UTC
If a username is > 242 bytes (highly unlikely, I know) then appending "/monobook.css" will put the page over the 255 byte limit.

The easiest solution would seem to be to limit user-names to a meagre 235 bytes (58 4-byte characters instead of the current 63 still seems perfectly long enough for something one has to type - and indeed enwiki uses Titleblacklist to reduce this to 40), and skin names to 15 (currently cologneblue is 11).
Comment 1 Church of emacs 2010-04-15 22:01:27 UTC
I think the problem is the too-long usernames, not this issue. I checked, it's actually a 255 character limit, not 255 bytes. Limit it to 2^6 chars?
Comment 2 Conrad Irwin 2010-04-15 22:13:36 UTC
What did you look at to work that out? 

I tried to create the page æ * 130 on Wikipedia, and that was a no-go (though æ * 120 is fine). [See also the comment on line 2535 of Title.php]. A byte limit makes most sense as that's what mysql enforces within a VARBINARY(255).
Comment 3 Conrad Irwin 2010-04-15 22:44:20 UTC
r65101
Comment 4 Church of emacs 2010-04-16 07:03:20 UTC
Uh, sorry, you're right. It's 255 byte, not characters. The fix looks fine, as long as we don't have real long skin names ("monobook" (8 chars) to "vector" (6 chars) has been an improvement ;))

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links