Last modified: 2010-04-20 22:50:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 23075 - MediaTransformError default width in gallery is incorrect
MediaTransformError default width in gallery is incorrect
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-06 23:31 UTC by Derk-Jan Hartman
Modified: 2010-04-20 22:50 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed changes to MediaTransformError (1.12 KB, patch)
2010-04-07 00:04 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2010-04-06 23:31:45 UTC
The default width of a MediaTransformError seems to be 180px, but in a gallery that is too wide. The better question might be, why is this in a table in the first place, and not simply in the thumb frame...
Comment 1 Derk-Jan Hartman 2010-04-06 23:47:44 UTC
It seems the smallest possible thumbs with this error are 180 atm. I'm not sure if we want to keep that, because it looks rather ugly http://commons.wikimedia.org/wiki/Category:Animations_of_geometry


from: includes/media/MediaTransformOutput.php
max( isset( $params['width']  ) ? $params['width']  : 0, 180 )
max( isset( $params['height'] ) ? $params['height'] : 0, 180 )
Comment 2 Derk-Jan Hartman 2010-04-07 00:04:43 UTC
Created attachment 7273 [details]
Proposed changes to MediaTransformError

This patch changes the minimum size of a MediaTransformError to 120px, which makes sure it will at least fit galleries. Any smaller and likely it would become unreadable, so keep the ugly in those cases.

The patch also changes the message from a table to a div, because there is no real need to use a table here. I have added "display:inline-block" to the css to make it behave almost exactly as an img or table element would (This might be important for [[File:image.gif|180px]], where no other framing is provided.)

I have no strong opinion on the usage of inline-block, I'll leave it up for debate.
Comment 3 Siebrand Mazeland 2010-04-20 22:50:09 UTC
Applied in r65350. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links